From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF1CC433E0 for ; Wed, 27 May 2020 14:54:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E48D2078B for ; Wed, 27 May 2020 14:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389414AbgE0Oyk (ORCPT ); Wed, 27 May 2020 10:54:40 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:36364 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388738AbgE0Oyi (ORCPT ); Wed, 27 May 2020 10:54:38 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 2E30C8030835; Wed, 27 May 2020 14:54:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E4y3rFoQNrPH; Wed, 27 May 2020 17:54:35 +0300 (MSK) Date: Wed, 27 May 2020 17:54:35 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Jarkko Nikula , Wolfram Sang , Mika Westerberg , Alexey Malahov , Thomas Bogendoerfer , Rob Herring , , , , Subject: Re: [PATCH v4 10/11] i2c: designware: Move reg-space remapping into a dedicated function Message-ID: <20200527145435.bfout2oyonupxlac@mobilestation> References: <20200527120111.5781-1-Sergey.Semin@baikalelectronics.ru> <20200527120111.5781-11-Sergey.Semin@baikalelectronics.ru> <20200527135801.GB1634618@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200527135801.GB1634618@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 04:58:01PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 03:01:10PM +0300, Serge Semin wrote: > > This is a preparation patch before adding a quirk with custom registers > > map creation required for the Baikal-T1 System I2C support. > > Looks good. Though one nit below. > Reviewed-by: Andy Shevchenko > > > Signed-off-by: Serge Semin > > Cc: Alexey Malahov > > Cc: Thomas Bogendoerfer > > Cc: Rob Herring > > Cc: linux-mips@vger.kernel.org > > Cc: devicetree@vger.kernel.org > > > > --- > > > > Changelog v3: > > - This is a new patch, which has been created due to declining the > > glue-layer approach. > > > > Changelog v4: > > - Use PTR_ERR_OR_ZERO() helper in the bt1_i2c_request_regs() method. > > - Discard devm_platform_get_and_ioremap_resource() utilization. > > --- > > drivers/i2c/busses/i2c-designware-platdrv.c | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > > index ad292de2d260..061c8d506c7c 100644 > > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > > @@ -108,6 +108,15 @@ static void dw_i2c_plat_pm_cleanup(struct dw_i2c_dev *dev) > > pm_runtime_put_noidle(dev->dev); > > } > > > > +static int dw_i2c_plat_request_regs(struct dw_i2c_dev *dev) > > +{ > > + struct platform_device *pdev = to_platform_device(dev->dev); > > + > > + dev->base = devm_platform_ioremap_resource(pdev, 0); > > + > > + return PTR_ERR_OR_ZERO(dev->base); > > +} > > + > > static int dw_i2c_plat_probe(struct platform_device *pdev) > > { > > struct dw_i2c_platform_data *pdata = dev_get_platdata(&pdev->dev); > > @@ -125,15 +134,14 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) > > return -ENOMEM; > > > > > dev->flags |= (uintptr_t)device_get_match_data(&pdev->dev); > > It's related to previous patch, but I just realized that '|' is not needed > here. Care to amend in the previous patch? Agreed. Thanks. -Sergey > > > - > > - dev->base = devm_platform_ioremap_resource(pdev, 0); > > - if (IS_ERR(dev->base)) > > - return PTR_ERR(dev->base); > > - > > dev->dev = &pdev->dev; > > dev->irq = irq; > > platform_set_drvdata(pdev, dev); > > > > + ret = dw_i2c_plat_request_regs(dev); > > + if (ret) > > + return ret; > > + > > dev->rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); > > if (IS_ERR(dev->rst)) > > return PTR_ERR(dev->rst); > > -- > > 2.26.2 > > > > -- > With Best Regards, > Andy Shevchenko > >