Hi Tiezhu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on v5.7-rc7 next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Tiezhu-Yang/clk-hisilicon-Use-correct-return-value-about-hisi_reset_init/20200525-113342 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: x86_64-randconfig-s021-20200527 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-240-gf0fe1cd9-dirty # save the attached .config to linux build tree make W=1 C=1 ARCH=x86_64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/clk/hisilicon/reset.c:100:28: sparse: sparse: incorrect type in return expression (different address spaces) @@ expected struct hisi_reset_controller * @@ got void [noderef] *membase @@ >> drivers/clk/hisilicon/reset.c:100:28: sparse: expected struct hisi_reset_controller * >> drivers/clk/hisilicon/reset.c:100:28: sparse: got void [noderef] *membase vim +100 drivers/clk/hisilicon/reset.c 25824d52caa8e61 Jiancheng Xue 2016-04-23 89 97b7129cd2afb47 Jiancheng Xue 2016-06-15 90 struct hisi_reset_controller *hisi_reset_init(struct platform_device *pdev) 25824d52caa8e61 Jiancheng Xue 2016-04-23 91 { 25824d52caa8e61 Jiancheng Xue 2016-04-23 92 struct hisi_reset_controller *rstc; 25824d52caa8e61 Jiancheng Xue 2016-04-23 93 97b7129cd2afb47 Jiancheng Xue 2016-06-15 94 rstc = devm_kmalloc(&pdev->dev, sizeof(*rstc), GFP_KERNEL); 25824d52caa8e61 Jiancheng Xue 2016-04-23 95 if (!rstc) 78847951203a978 Tiezhu Yang 2020-05-25 96 return ERR_PTR(-ENOMEM); 25824d52caa8e61 Jiancheng Xue 2016-04-23 97 75cc0a123c90c8e YueHaibing 2019-10-14 98 rstc->membase = devm_platform_ioremap_resource(pdev, 0); e9a2310fb689151 Gustavo A. R. Silva 2018-07-25 99 if (IS_ERR(rstc->membase)) 78847951203a978 Tiezhu Yang 2020-05-25 @100 return rstc->membase; 25824d52caa8e61 Jiancheng Xue 2016-04-23 101 25824d52caa8e61 Jiancheng Xue 2016-04-23 102 spin_lock_init(&rstc->lock); 25824d52caa8e61 Jiancheng Xue 2016-04-23 103 rstc->rcdev.owner = THIS_MODULE; 25824d52caa8e61 Jiancheng Xue 2016-04-23 104 rstc->rcdev.ops = &hisi_reset_ops; 97b7129cd2afb47 Jiancheng Xue 2016-06-15 105 rstc->rcdev.of_node = pdev->dev.of_node; 25824d52caa8e61 Jiancheng Xue 2016-04-23 106 rstc->rcdev.of_reset_n_cells = 2; 25824d52caa8e61 Jiancheng Xue 2016-04-23 107 rstc->rcdev.of_xlate = hisi_reset_of_xlate; 25824d52caa8e61 Jiancheng Xue 2016-04-23 108 reset_controller_register(&rstc->rcdev); 25824d52caa8e61 Jiancheng Xue 2016-04-23 109 25824d52caa8e61 Jiancheng Xue 2016-04-23 110 return rstc; 25824d52caa8e61 Jiancheng Xue 2016-04-23 111 } 25824d52caa8e61 Jiancheng Xue 2016-04-23 112 EXPORT_SYMBOL_GPL(hisi_reset_init); 25824d52caa8e61 Jiancheng Xue 2016-04-23 113 :::::: The code at line 100 was first introduced by commit :::::: 78847951203a978f4544f9e7dd244a3930b3945b clk: hisilicon: Use correct return value about hisi_reset_init() :::::: TO: Tiezhu Yang :::::: CC: 0day robot --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org