From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org, will@kernel.org, tglx@linutronix.de
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
a.darwish@linutronix.de, rostedt@goodmis.org,
bigeasy@linutronix.de
Subject: Re: [PATCH 0/6] x86/entry,lockdep: Improve IRQ state tracking
Date: Wed, 27 May 2020 18:43:05 +0200 [thread overview]
Message-ID: <20200527164305.GB706495@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200527154527.233385756@infradead.org>
On Wed, May 27, 2020 at 05:45:27PM +0200, Peter Zijlstra wrote:
> Ahmed and Sebastian wanted additional lockdep_assert*() macros and ran
> into header hell.
>
> Move the IRQ state into per-cpu variables, which removes the dependency on
> task_struct, which is what generated the header-hell.
>
> And fix IRQ state tracking to not be affected by lockdep_off() (it really
> should not have been anyway) and extends IRQ state tracking across (x86)
> NMIs.
After having it run kernel builds for a while, I've got a realy weird
(false-positive) lockdep_assert_irqs_enabled() trigger.
So something isn't quite right. I'll prod at it some moar.
prev parent reply other threads:[~2020-05-27 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 15:45 [PATCH 0/6] x86/entry,lockdep: Improve IRQ state tracking Peter Zijlstra
2020-05-27 15:45 ` [PATCH 1/6] x86/entry: Clarify irq_{enter,exit}_rcu() Peter Zijlstra
2020-05-27 15:45 ` [PATCH 2/6] lockdep: Change hardirq{s_enabled,_context} to per-cpu variables Peter Zijlstra
2020-05-27 17:39 ` Peter Zijlstra
2020-05-27 15:45 ` [PATCH 3/6] lockdep: Remove lockdep_hardirq{s_enabled,_context}() argument Peter Zijlstra
2020-05-27 15:45 ` [PATCH 4/6] x86/entry: Rename trace_hardirqs_off_prepare() Peter Zijlstra
2020-05-27 15:45 ` [PATCH 5/6] lockdep: Prepare for NMI IRQ state tracking Peter Zijlstra
2020-05-27 15:45 ` [PATCH 6/6] x86/entry: Fix NMI vs " Peter Zijlstra
2020-05-27 16:43 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527164305.GB706495@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=a.darwish@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).