From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB67C433E0 for ; Wed, 27 May 2020 16:43:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FB1720873 for ; Wed, 27 May 2020 16:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391419AbgE0QnQ (ORCPT ); Wed, 27 May 2020 12:43:16 -0400 Received: from mga18.intel.com ([134.134.136.126]:25364 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391358AbgE0QnP (ORCPT ); Wed, 27 May 2020 12:43:15 -0400 IronPort-SDR: 7f4nT+5OQ9oAR8kixpeIl2svcHUSwdjIkFV0fcafFolj1S2bE04STfWappG+kaA5UcBaDCVEX2 S8zMm9z1YXIQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2020 09:43:14 -0700 IronPort-SDR: UnREJ0zffizlBgwZuaP50WVkE+7uT6va26qL5z0Mfk+YV8hQqUDvIkUnCC3WarTa9EXmWlqkAm 9KozwRyZSBDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,442,1583222400"; d="scan'208";a="266897448" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003.jf.intel.com with ESMTP; 27 May 2020 09:43:11 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jdz98-009GJc-Co; Wed, 27 May 2020 19:43:14 +0300 Date: Wed, 27 May 2020 19:43:14 +0300 From: Andy Shevchenko To: Serge Semin Cc: Serge Semin , Jarkko Nikula , Wolfram Sang , Alexey Malahov , Thomas Bogendoerfer , Mika Westerberg , Rob Herring , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency Message-ID: <20200527164314.GR1634618@smile.fi.intel.com> References: <20200527120111.5781-1-Sergey.Semin@baikalelectronics.ru> <20200527120111.5781-7-Sergey.Semin@baikalelectronics.ru> <20200527134220.GX1634618@smile.fi.intel.com> <20200527142406.jzdtkbdb2q6st7e6@mobilestation> <20200527154632.GG1634618@smile.fi.intel.com> <20200527160056.rg66gsubwhrwtnwf@mobilestation> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527160056.rg66gsubwhrwtnwf@mobilestation> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 07:00:56PM +0300, Serge Semin wrote: > On Wed, May 27, 2020 at 06:46:32PM +0300, Andy Shevchenko wrote: > > On Wed, May 27, 2020 at 05:24:06PM +0300, Serge Semin wrote: > > > On Wed, May 27, 2020 at 04:42:20PM +0300, Andy Shevchenko wrote: > > > > On Wed, May 27, 2020 at 03:01:06PM +0300, Serge Semin wrote: > > > > > Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C > > > > > platform driver. It's a bit confusing to see it's config in the menu at > > > > > some separated place with no reference to the platform code. Let's move the > > > > > config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark > > > > > it with "depends on I2C_DESIGNWARE_PLATFORM" statement. By doing so the > > > > > config menu will display the feature right below the DW I2C platform > > > > > driver item and will indent it to the right so signifying its belonging. > > > > ... > > > > > > > config I2C_DESIGNWARE_BAYTRAIL > > > > > bool "Intel Baytrail I2C semaphore support" > > > > > depends on ACPI > > > > > + depends on I2C_DESIGNWARE_PLATFORM > > > > > depends on (I2C_DESIGNWARE_PLATFORM=m && IOSF_MBI) || \ > > > > > (I2C_DESIGNWARE_PLATFORM=y && IOSF_MBI=y) > > > > > > > > I didn't get this. What is broken now with existing dependencies? > > > > > > With no explicit "depends on I2C_DESIGNWARE_PLATFORM" the entry isn't right > > > shifted with respect to the I2C_DESIGNWARE_PLATFORM config entry in the kernel > > > menuconfig. So it looks like a normal no-yes driver without it. > > > > I didn't get. Is there problems with current case? (I don't see it). > > If there is a problem, it should have a separate patch and commit message. > > > > As for now above excerpt seems redundant and unneeded churn. > > Please read the commit log more carefully. > > Without explicit "depends on I2C_DESIGNWARE_PLATFORM" you'd see the DW > I2C-related menuconfig as: > [*] Synopsys DesignWare Platform > [ ] Intel Baytrail I2C semaphore support > with that "depends on I2C_DESIGNWARE_PLATFORM" added: > [*] Synopsys DesignWare Platform > [ ] Intel Baytrail I2C semaphore support > The second case presents the Baytrail semaphore as the DW I2C platform > feature. Otherwise it's just a simple menuentry. As I see it without adding > the explicit "depends on I2C_DESIGNWARE_PLATFORM" there is no need in moving > the config at all. Thanks for explanation, this makes sense. > So if you think it's a churn. Well, I'll wait for > Jarkko' comment in this regard. > > BTW Jarkko asked in v3 whether it would work with just explicit "depends on" > without if-endif enclosing the config. > > -Sergey > > > > > -- > > With Best Regards, > > Andy Shevchenko > > > > -- With Best Regards, Andy Shevchenko