From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Maxim Kaurkin <maxim.kaurkin@baikalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
<linux-mips@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-hwmon@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] hwmon: Add Baikal-T1 PVT sensor driver
Date: Wed, 27 May 2020 20:05:24 +0300 [thread overview]
Message-ID: <20200527170524.hbjbikp5b6e5nw5l@mobilestation> (raw)
In-Reply-To: <14256f0f-2977-4a54-cf01-ae7e684d10c2@roeck-us.net>
On Wed, May 27, 2020 at 09:58:00AM -0700, Guenter Roeck wrote:
> On 5/27/20 9:52 AM, Serge Semin wrote:
> > On Wed, May 27, 2020 at 09:25:49AM -0700, Guenter Roeck wrote:
> >> On Tue, May 26, 2020 at 04:38:23PM +0300, Serge Semin wrote:
> >
> > [nip]
> >
> >>> +
> >>> +=============================== ======= =======================================
> >>> +Name Perm Description
> >>> +=============================== ======= =======================================
> >>> +update_interval RW Measurements update interval per
> >>> + sensor.
> >>> +temp1_type RO Sensor type (always 1 as CPU embedded
> >>> + diode).
> >>> +temp1_label RO CPU Core Temperature sensor.
> >>> +temp1_input RO Measured temperature in millidegree
> >>> + Celsius.
> >>> +temp1_min RW Low limit for temp input.
> >>> +temp1_max RW High limit for temp input.
> >>> +temp1_min_alarm RO Temperature input alarm. Returns 1 if
> >>> + temperature input went below min limit,
> >>> + 0 otherwise.
> >>> +temp1_max_alarm RO Temperature input alarm. Returns 1 if
> >>> + temperature input went above max limit,
> >>> + 0 otherwise.
> >>> +temp1_trim RW Temperature sensor trimming factor in
> >>> + millidegree Celsius. It can be used to
> >>> + manually adjust the temperature
> >>> + measurements within 7.130 degrees
> >>> + Celsius.
> >>
> >> vs. standard ABI:
> >>
> >> temp[1-*]_offset`
> >> Temperature offset which is added to the temperature reading
> >> by the chip.
> >>
> >> Unit: millidegree Celsius
> >>
> >> If you really think this is necessary, why not use the standard ABI ?
> >
> > That would have made much more sense.) I'll replace the handwritten temp1_trim
> > with the standard temp1_offset attribute in v4 shortly today. Thanks for pointing
> > this out.
> >
>
> Sorry for not realizing this earlier. The added explanation
> made all the difference.
No worries. I'll fix it in v4. What about the clk_get_rate() part of the code?
You had a comment regarding it in v2. I responded with justification that we can
leave it as is. If you still disagree, then I create the clock rate caching in the
private data at the probe() stage.
-Sergey
>
> Guenter
next prev parent reply other threads:[~2020-05-27 17:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 13:38 [PATCH v3 0/3] hwmon: Add Baikal-T1 SoC Process, Voltage and Temp sensor support Serge Semin
2020-05-26 13:38 ` [PATCH v3 1/3] dt-bindings: hwmon: Add Baikal-T1 PVT sensor binding Serge Semin
2020-05-26 13:38 ` [PATCH v3 2/3] hwmon: Add notification support Serge Semin
2020-05-26 13:38 ` [PATCH v3 3/3] hwmon: Add Baikal-T1 PVT sensor driver Serge Semin
2020-05-27 16:25 ` Guenter Roeck
2020-05-27 16:52 ` Serge Semin
2020-05-27 16:58 ` Guenter Roeck
2020-05-27 17:05 ` Serge Semin [this message]
2020-05-27 18:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527170524.hbjbikp5b6e5nw5l@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maxim.kaurkin@baikalelectronics.ru \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).