From: David Miller <davem@davemloft.net>
To: wu000273@umn.edu
Cc: kjlu@umn.edu, j.vosburgh@gmail.com, vfalico@gmail.com,
andy@greyhouse.net, kuba@kernel.org, sfeldma@cumulusnetworks.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bonding: Fix reference count leak in bond_sysfs_slave_add.
Date: Thu, 28 May 2020 11:08:55 -0700 (PDT) [thread overview]
Message-ID: <20200528.110855.1734440342981569253.davem@davemloft.net> (raw)
In-Reply-To: <20200528031029.11078-1-wu000273@umn.edu>
From: wu000273@umn.edu
Date: Wed, 27 May 2020 22:10:29 -0500
> From: Qiushi Wu <wu000273@umn.edu>
>
> kobject_init_and_add() takes reference even when it fails.
> If this function returns an error, kobject_put() must be called to
> properly clean up the memory associated with the object. Previous
> commit "b8eb718348b8" fixed a similar problem.
>
> Fixes: 07699f9a7c8d ("bonding: add sysfs /slave dir for bond slave devices.")
> Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2020-05-28 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:10 [PATCH] bonding: Fix reference count leak in bond_sysfs_slave_add wu000273
2020-05-28 16:18 ` Jay Vosburgh
2020-05-28 18:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528.110855.1734440342981569253.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=kjlu@umn.edu \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@cumulusnetworks.com \
--cc=vfalico@gmail.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).