From: Alim Akhtar <alim.akhtar@samsung.com>
To: robh@kernel.org
Cc: devicetree@vger.kernel.org, linux-scsi@vger.kernel.org,
krzk@kernel.org, avri.altman@wdc.com, martin.petersen@oracle.com,
kwmad.kim@samsung.com, stanley.chu@mediatek.com,
cang@codeaurora.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: [PATCH v10 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr
Date: Thu, 28 May 2020 06:46:49 +0530 [thread overview]
Message-ID: <20200528011658.71590-2-alim.akhtar@samsung.com> (raw)
In-Reply-To: <20200528011658.71590-1-alim.akhtar@samsung.com>
In the right behavior, setting the bit to '0' indicates clear and '1'
indicates no change. If host controller handles this the other way,
UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR can be used.
Reviewed-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Seungwon Jeon <essuuj@gmail.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
drivers/scsi/ufs/ufshcd.c | 11 +++++++++--
drivers/scsi/ufs/ufshcd.h | 5 +++++
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 698e8d20b4ba..3655b88fc862 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -645,7 +645,11 @@ static inline int ufshcd_get_tr_ocs(struct ufshcd_lrb *lrbp)
*/
static inline void ufshcd_utrl_clear(struct ufs_hba *hba, u32 pos)
{
- ufshcd_writel(hba, ~(1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR);
+ if (hba->quirks & UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR)
+ ufshcd_writel(hba, (1 << pos), REG_UTP_TRANSFER_REQ_LIST_CLEAR);
+ else
+ ufshcd_writel(hba, ~(1 << pos),
+ REG_UTP_TRANSFER_REQ_LIST_CLEAR);
}
/**
@@ -655,7 +659,10 @@ static inline void ufshcd_utrl_clear(struct ufs_hba *hba, u32 pos)
*/
static inline void ufshcd_utmrl_clear(struct ufs_hba *hba, u32 pos)
{
- ufshcd_writel(hba, ~(1 << pos), REG_UTP_TASK_REQ_LIST_CLEAR);
+ if (hba->quirks & UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR)
+ ufshcd_writel(hba, (1 << pos), REG_UTP_TASK_REQ_LIST_CLEAR);
+ else
+ ufshcd_writel(hba, ~(1 << pos), REG_UTP_TASK_REQ_LIST_CLEAR);
}
/**
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 6ffc08ad85f6..071f0edf3f64 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -518,6 +518,11 @@ enum ufshcd_quirks {
* ops (get_ufs_hci_version) to get the correct version.
*/
UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION = 1 << 5,
+
+ /*
+ * Clear handling for transfer/task request list is just opposite.
+ */
+ UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR = 1 << 6,
};
enum ufshcd_caps {
--
2.17.1
next prev parent reply other threads:[~2020-05-28 1:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200528013223epcas5p2be85fa8803326b49a905fb7225992cad@epcas5p2.samsung.com>
2020-05-28 1:16 ` [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar
[not found] ` <CGME20200528013226epcas5p1c73527c71424679443c10daf8bf561df@epcas5p1.samsung.com>
2020-05-28 1:16 ` Alim Akhtar [this message]
[not found] ` <CGME20200528013228epcas5p4641c271e319aaefc78d7bbd22b23c30f@epcas5p4.samsung.com>
2020-05-28 1:16 ` [PATCH v10 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar
[not found] ` <CGME20200528013230epcas5p37b2d1980cfccf593242bef11e2076eb8@epcas5p3.samsung.com>
2020-05-28 1:16 ` [PATCH v10 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
[not found] ` <CGME20200528013232epcas5p32fecbbebc06909ff1fa7136481891dc1@epcas5p3.samsung.com>
2020-05-28 1:16 ` [PATCH v10 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar
[not found] ` <CGME20200528013234epcas5p2fe5412e2775ff9b28a1b29e8e30ab69c@epcas5p2.samsung.com>
2020-05-28 1:16 ` [PATCH v10 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Alim Akhtar
[not found] ` <CGME20200528013236epcas5p3cc936778eabd07450fbb7f03a17fe757@epcas5p3.samsung.com>
2020-05-28 1:16 ` [PATCH v10 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar
[not found] ` <CGME20200528013238epcas5p3c00d834dbb0b26cc683f293385d77178@epcas5p3.samsung.com>
2020-05-28 1:16 ` [PATCH v10 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar
[not found] ` <CGME20200528013240epcas5p38d53c6e320065b40bda434c49efad57a@epcas5p3.samsung.com>
2020-05-28 1:16 ` [PATCH v10 08/10] dt-bindings: ufs: Add bindings for Samsung ufs host Alim Akhtar
[not found] ` <CGME20200528013243epcas5p460a041d543b9acfbaa923f38709740b0@epcas5p4.samsung.com>
2020-05-28 1:16 ` [PATCH v10 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
[not found] ` <CGME20200528013245epcas5p37851891649512882c7b1ffb5f903c506@epcas5p3.samsung.com>
2020-05-28 1:16 ` [PATCH v10 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar
2020-05-29 8:05 ` Krzysztof Kozlowski
2020-06-01 1:30 ` Alim Akhtar
2020-06-01 1:40 ` [PATCH v10 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar
2020-06-03 2:31 ` Martin K. Petersen
2020-06-08 2:45 ` Alim Akhtar
2020-06-08 2:52 ` Kishon Vijay Abraham I
2020-06-11 15:18 ` Alim Akhtar
2020-06-20 1:59 ` Alim Akhtar
2020-06-24 10:21 ` Vinod Koul
2020-06-24 16:57 ` Alim Akhtar
2020-06-24 17:30 ` Vinod Koul
2020-06-25 0:21 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528011658.71590-2-alim.akhtar@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=robh@kernel.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).