From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9520C433E1 for ; Thu, 28 May 2020 14:49:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A2DC207D3 for ; Thu, 28 May 2020 14:49:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WKRbF5YZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391272AbgE1OtA (ORCPT ); Thu, 28 May 2020 10:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391239AbgE1Os5 (ORCPT ); Thu, 28 May 2020 10:48:57 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8829EC05BD1E for ; Thu, 28 May 2020 07:48:57 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id f3so793102pfd.11 for ; Thu, 28 May 2020 07:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+xcbrWR7v9ZYLl1sP0EPA1s9q3WS54xiSjaNFzwrenw=; b=WKRbF5YZjCsreLkXFNFcebIWYkoO/TejBuuJ/StesHfX6eKnXh5jJrZEpLcNZlLxbW jeU5R14V458eG49PHzwXNLtTbnq1PABRINAVwnpXLrjQ3Tk8v+q8H0FO2KZQWagjZ1yZ 470O/3McXPV4xTmFWoOCg/N0i7oUCLuGcD3KU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+xcbrWR7v9ZYLl1sP0EPA1s9q3WS54xiSjaNFzwrenw=; b=UQqAUcmd2HAMqLrz9aH6PmjvomJfZ9PO5862FmAaTQb2jL0zYOr64AtyO37YsPYgeu jX3vyBOW+2alojvAuzePkHYOyiPAyccBRExm1n55TKVFqA5dVOWs0bLGbGdLWUyeQMbr A9Txe1iQsxv+TJegfCRBYkHPhWf2eF88UxkuPotRl/LMk4UIsjQKpk0f5S6/WoiyO+XA KkmYhQShZ0mX3E/IAJS8bGoN4NWskopBGlBAf74nqeogfNOoJwmYMoP6zJdlapC+7nJl df/qZzH0gBgEqHyLUcGa3Z5DfdIHjB+5ViUYiQYWDLZ0VhCclAQJCagoybyP+h4nBBUJ ioXA== X-Gm-Message-State: AOAM533DidUSyUou26axwVBLQcxuQA4qlL418fCDXl22/ufcPQuJfo89 p/UBfhTXf0hiCQOEOHZoDxHzwg== X-Google-Smtp-Source: ABdhPJzwD84u+Vw75JRFS6NQbAsojOVeeIBcOVutQLCL5YY+/L8irWWHwPxPEd7rJ6uoCwXmsXkEMg== X-Received: by 2002:a63:fc0e:: with SMTP id j14mr3368356pgi.264.1590677337039; Thu, 28 May 2020 07:48:57 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id l192sm4971971pfd.169.2020.05.28.07.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 07:48:56 -0700 (PDT) From: Douglas Anderson To: Andy Gross , Bjorn Andersson Cc: Maulik Shah , Douglas Anderson , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: qcom: rpmh-rsc: Don't use ktime for timeout in write_tcs_reg_sync() Date: Thu, 28 May 2020 07:48:34 -0700 Message-Id: <20200528074530.1.Ib86e5b406fe7d16575ae1bb276d650faa144b63c@changeid> X-Mailer: git-send-email 2.27.0.rc0.183.gde8f92d652-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The write_tcs_reg_sync() may be called after timekeeping is suspended so it's not OK to use ktime. The readl_poll_timeout_atomic() macro implicitly uses ktime. This was causing a warning at suspend time. Change to just loop 1000000 times with a delay of 1 us between loops. This may give a timeout of more than 1 second but never less and is safe even if timekeeping is suspended. NOTE: I don't have any actual evidence that we need to loop here. It's possibly that all we really need to do is just read the value back to ensure that the pipes are cleaned and the looping/comparing is totally not needed. I never saw the loop being needed in my tests. However, the loop shouldn't hurt. Fixes: 91160150aba0 ("soc: qcom: rpmh-rsc: Timeout after 1 second in write_tcs_reg_sync()") Reported-by: Maulik Shah Signed-off-by: Douglas Anderson --- drivers/soc/qcom/rpmh-rsc.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c index 076fd27f3081..906778e2c1fa 100644 --- a/drivers/soc/qcom/rpmh-rsc.c +++ b/drivers/soc/qcom/rpmh-rsc.c @@ -175,13 +175,21 @@ static void write_tcs_reg(const struct rsc_drv *drv, int reg, int tcs_id, static void write_tcs_reg_sync(const struct rsc_drv *drv, int reg, int tcs_id, u32 data) { - u32 new_data; + int i; writel(data, tcs_reg_addr(drv, reg, tcs_id)); - if (readl_poll_timeout_atomic(tcs_reg_addr(drv, reg, tcs_id), new_data, - new_data == data, 1, USEC_PER_SEC)) - pr_err("%s: error writing %#x to %d:%#x\n", drv->name, - data, tcs_id, reg); + + /* + * Wait until we read back the same value. Use a counter rather than + * ktime for timeout since this may be called after timekeeping stops. + */ + for (i = 0; i < USEC_PER_SEC; i++) { + if (readl(tcs_reg_addr(drv, reg, tcs_id)) == data) + return; + udelay(1); + } + pr_err("%s: error writing %#x to %d:%#x\n", drv->name, + data, tcs_id, reg); } /** -- 2.27.0.rc0.183.gde8f92d652-goog