From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92304C433E1 for ; Thu, 28 May 2020 08:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BC6021475 for ; Thu, 28 May 2020 08:39:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbgE1Ij3 (ORCPT ); Thu, 28 May 2020 04:39:29 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:40208 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726955AbgE1Ij2 (ORCPT ); Thu, 28 May 2020 04:39:28 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 6C2CF80307C0; Thu, 28 May 2020 08:39:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ionmEv71tfBL; Thu, 28 May 2020 11:39:24 +0300 (MSK) Date: Thu, 28 May 2020 11:39:23 +0300 From: Serge Semin To: Andy Shevchenko CC: Serge Semin , Rob Herring , Jarkko Nikula , Wolfram Sang , Alexey Malahov , Thomas Bogendoerfer , Mika Westerberg , , , , Subject: Re: [PATCH v4 02/11] dt-bindings: i2c: Discard i2c-slave flag from the DW I2C example Message-ID: <20200528083923.yjlm5ur7cslgxdau@mobilestation> References: <20200527120111.5781-1-Sergey.Semin@baikalelectronics.ru> <20200527120111.5781-3-Sergey.Semin@baikalelectronics.ru> <20200527171204.GA2348490@bogus> <20200527171841.am2iaynff243xoep@mobilestation> <20200527175624.GT1634618@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200527175624.GT1634618@smile.fi.intel.com> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 08:56:24PM +0300, Andy Shevchenko wrote: > On Wed, May 27, 2020 at 08:18:41PM +0300, Serge Semin wrote: > > On Wed, May 27, 2020 at 11:12:04AM -0600, Rob Herring wrote: > > > On Wed, May 27, 2020 at 03:01:02PM +0300, Serge Semin wrote: > > > > dtc currently doesn't support I2C_OWN_SLAVE_ADDRESS flag set in the > > > > i2c "reg" property. If it is the compiler will print a warning: > > > > > > > > Warning (i2c_bus_reg): /example-2/i2c@1120000/eeprom@64: I2C bus unit address format error, expected "40000064" > > > > Warning (i2c_bus_reg): /example-2/i2c@1120000/eeprom@64:reg: I2C address must be less than 10-bits, got "0x40000064" > > > > > > > > In order to silence dtc up let's discard the flag from the DW I2C DT > > > > binding example for now. Just revert this commit when dtc is fixed. > > > > > eeprom@64 { > > > > compatible = "linux,slave-24c02"; > > > > - reg = <0x40000064>; > > > > + reg = <0x64>; > > > > > > But the compatible is a slave, so you need an example with a different > > > device. > > > > > Ok. I'll replace the sub-node with just "atmel,24c02" compatible string then. > > But how it will be different to the another slave connected to the master? > > This example is specifically to show that DesingWare I²C controller may be > switched to slave mode. Well, dtc doesn't support it and prints warning that the address is invalid. Though I do understand you concern and is mostly agree with it. Let's do this in the next way. I'll resend the series with eeprom@64 sub-node replaced with just a normal eeprom-device. The message log will have an info why this has been done. In the non-mergeable section of the patch I'll suggest to Rob reconsider the patch acking, since we can leave the slave-marked sub-node and just live with the dtc warning until it's fixed in there. -Sergey > > > > > }; > > > > }; > > > > - | > > -- > With Best Regards, > Andy Shevchenko > >