* [PATCH] btrfs: select FS_IOMAP
@ 2020-05-28 9:16 Arnd Bergmann
2020-05-28 9:18 ` Johannes Thumshirn
2020-05-28 12:05 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-05-28 9:16 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, David Sterba, Goldwyn Rodrigues
Cc: Arnd Bergmann, Johannes Thumshirn, YueHaibing, linux-btrfs, linux-kernel
As btrfs now calls iomap_dio_rw, the helper code actually has
to be enabled to avoid a link error:
ERROR: modpost: "iomap_dio_rw" [fs/btrfs/btrfs.ko] undefined!
Fixes: f31e5f70919f ("btrfs: switch to iomap_dio_rw() for dio")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/btrfs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 575636f6491e..68b95ad82126 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -14,6 +14,7 @@ config BTRFS_FS
select LZO_DECOMPRESS
select ZSTD_COMPRESS
select ZSTD_DECOMPRESS
+ select FS_IOMAP
select RAID6_PQ
select XOR_BLOCKS
select SRCU
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: select FS_IOMAP
2020-05-28 9:16 [PATCH] btrfs: select FS_IOMAP Arnd Bergmann
@ 2020-05-28 9:18 ` Johannes Thumshirn
2020-05-28 12:05 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2020-05-28 9:18 UTC (permalink / raw)
To: Arnd Bergmann, Chris Mason, Josef Bacik, David Sterba, Goldwyn Rodrigues
Cc: Johannes Thumshirn, YueHaibing, linux-btrfs, linux-kernel
Right,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: select FS_IOMAP
2020-05-28 9:16 [PATCH] btrfs: select FS_IOMAP Arnd Bergmann
2020-05-28 9:18 ` Johannes Thumshirn
@ 2020-05-28 12:05 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2020-05-28 12:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Chris Mason, Josef Bacik, David Sterba, Goldwyn Rodrigues,
Johannes Thumshirn, YueHaibing, linux-btrfs, linux-kernel
On Thu, May 28, 2020 at 11:16:42AM +0200, Arnd Bergmann wrote:
> As btrfs now calls iomap_dio_rw, the helper code actually has
> to be enabled to avoid a link error:
>
> ERROR: modpost: "iomap_dio_rw" [fs/btrfs/btrfs.ko] undefined!
>
> Fixes: f31e5f70919f ("btrfs: switch to iomap_dio_rw() for dio")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, I've folded the patch in so we don't get build breakage in the
patches between the two.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-28 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 9:16 [PATCH] btrfs: select FS_IOMAP Arnd Bergmann
2020-05-28 9:18 ` Johannes Thumshirn
2020-05-28 12:05 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).