From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Matt Helsley <mhelsley@vmware.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [RFC][PATCH 2/3] objtool: Find relocation base section using sh_info
Date: Thu, 28 May 2020 09:09:16 -0500 [thread overview]
Message-ID: <20200528140916.6crguzfpehf6lext@treble> (raw)
In-Reply-To: <d848189dac6c41193a6c55c3588b78114bbcb0f8.1590597288.git.mhelsley@vmware.com>
On Wed, May 27, 2020 at 09:42:32AM -0700, Matt Helsley wrote:
> Currently objtool uses a naming heuristic to find the "base"
> section to apply the relocation(s) to. The standard defines
> the SHF_INFO_LINK flag (SHF => in the section header flags)
> which indicates when the section header's sh_info field can
> be used to find the necessary section.
>
> Warns when the heuristic is used as a fallback and changes
> the name heuristic calculation to handle rela (explicit
> addend) and now rel (implicit addend) relocations.
Does this fallback case actually happen?
--
Josh
next prev parent reply other threads:[~2020-05-28 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 16:42 [RFC][PATCH 0/3] objtool: Support implicit addend relocations Matt Helsley
2020-05-27 16:42 ` [RFC][PATCH 1/3] objtool: Rename rela to reloc Matt Helsley
2020-05-28 14:04 ` Josh Poimboeuf
2020-05-28 16:00 ` Matt Helsley
2020-05-27 16:42 ` [RFC][PATCH 2/3] objtool: Find relocation base section using sh_info Matt Helsley
2020-05-28 14:09 ` Josh Poimboeuf [this message]
2020-05-28 16:02 ` Matt Helsley
2020-05-28 17:00 ` Josh Poimboeuf
2020-05-28 19:15 ` Matt Helsley
2020-05-27 16:42 ` [RFC][PATCH 3/3] objtool: Add support for relocations without addends Matt Helsley
2020-05-28 14:24 ` Josh Poimboeuf
2020-05-28 16:05 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528140916.6crguzfpehf6lext@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhelsley@vmware.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).