From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Olof Johansson <olof@lixom.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<soc@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/6] bus: bt1-apb: Use sysfs_streq instead of strncmp
Date: Thu, 28 May 2020 17:50:48 +0300 [thread overview]
Message-ID: <20200528145050.5203-4-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20200528145050.5203-1-Sergey.Semin@baikalelectronics.ru>
There is a ready-to-use method to compare a retrieved from a sysfs node
string with another string. It treats both NUL and newline-then-NUL as
equivalent string terminations. So use it instead of manually truncating
the line length in the strncmp() method.
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: soc@kernel.org
---
drivers/bus/bt1-apb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/bt1-apb.c b/drivers/bus/bt1-apb.c
index 7e57fc2af745..b25ff941e7c7 100644
--- a/drivers/bus/bt1-apb.c
+++ b/drivers/bus/bt1-apb.c
@@ -325,9 +325,9 @@ static ssize_t inject_error_store(struct device *dev,
* Either dummy read from the unmapped address in the APB IO area
* or manually set the IRQ status.
*/
- if (!strncmp(data, "nodev", 5))
+ if (sysfs_streq(data, "nodev"))
readl(apb->res);
- else if (!strncmp(data, "irq", 3))
+ else if (sysfs_streq(data, "irq"))
regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING,
APB_EHB_ISR_PENDING);
else
--
2.26.2
next prev parent reply other threads:[~2020-05-28 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:50 [PATCH 1/6] bus: bt1-apb: Include linux/io.h Serge Semin
2020-05-28 14:50 ` [PATCH 2/6] bus: bt1-apb: Fix show/store callback identations Serge Semin
2020-05-28 14:50 ` [PATCH 3/6] bus: bt1-apb: Use PTR_ERR_OR_ZERO to return from request-regs method Serge Semin
2020-05-28 14:50 ` Serge Semin [this message]
2020-05-28 14:50 ` [PATCH 5/6] bus: bt1-axi: Optimize the return points in the driver Serge Semin
2020-05-28 14:50 ` [PATCH 6/6] bus: bt1-axi: Use sysfs_streq instead of strncmp Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528145050.5203-4-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).