From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4835CC433E0 for ; Thu, 28 May 2020 18:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FEE9208A7 for ; Thu, 28 May 2020 18:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406038AbgE1S44 (ORCPT ); Thu, 28 May 2020 14:56:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405981AbgE1S4z (ORCPT ); Thu, 28 May 2020 14:56:55 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AC0FC08C5C6; Thu, 28 May 2020 11:56:55 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.93 #3 (Red Hat Linux)) id 1jeNhr-00H4In-6U; Thu, 28 May 2020 18:56:43 +0000 Date: Thu, 28 May 2020 19:56:43 +0100 From: Al Viro To: Christoph Hellwig Cc: Linus Torvalds , Ian Kent , David Howells , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH 06/14] fs: remove the call_{read,write}_iter functions Message-ID: <20200528185643.GL23230@ZenIV.linux.org.uk> References: <20200528054043.621510-1-hch@lst.de> <20200528054043.621510-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528054043.621510-7-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 07:40:35AM +0200, Christoph Hellwig wrote: > Just open coding the methods calls is a lot easier to follow. Not sure about this one, TBH - it's harder to grep that way, since you get all the initializers for read_iter/write_iter thrown into the mix. Sure, you can do something like '\->[ ]*read_iter\>', but it's a PITA.