From: Kaaira Gupta <kgupta@es.iitr.ac.in>
To: Helen Koike <helen.koike@collabora.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kieran.bingham@ideasonboard.com
Subject: [PATCH] vimc: debayer: Add support for ARGB format
Date: Fri, 29 May 2020 00:27:17 +0530 [thread overview]
Message-ID: <20200528185717.GA20581@kaaira-HP-Pavilion-Notebook> (raw)
Running qcam for pixelformat 0x34324142 showed that vimc debayer does
not support it. Hence, add the support for Alpha (255).
Signed-off-by: Kaaira Gupta <kgupta@es.iitr.ac.in>
---
.../media/test-drivers/vimc/vimc-debayer.c | 27 ++++++++++++-------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/media/test-drivers/vimc/vimc-debayer.c b/drivers/media/test-drivers/vimc/vimc-debayer.c
index c3f6fef34f68..f34148717a40 100644
--- a/drivers/media/test-drivers/vimc/vimc-debayer.c
+++ b/drivers/media/test-drivers/vimc/vimc-debayer.c
@@ -62,6 +62,7 @@ static const u32 vimc_deb_src_mbus_codes[] = {
MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
MEDIA_BUS_FMT_RGB888_1X32_PADHI,
+ MEDIA_BUS_FMT_ARGB8888_1X32
};
static const struct vimc_deb_pix_map vimc_deb_pix_map_list[] = {
@@ -322,15 +323,23 @@ static void vimc_deb_process_rgb_frame(struct vimc_deb_device *vdeb,
unsigned int i, index;
vpix = vimc_pix_map_by_code(vdeb->src_code);
- index = VIMC_FRAME_INDEX(lin, col, vdeb->sink_fmt.width, 3);
- for (i = 0; i < 3; i++) {
- switch (vpix->pixelformat) {
- case V4L2_PIX_FMT_RGB24:
- vdeb->src_frame[index + i] = rgb[i];
- break;
- case V4L2_PIX_FMT_BGR24:
- vdeb->src_frame[index + i] = rgb[2 - i];
- break;
+
+ if (vpix->pixelformat == V4L2_PIX_FMT_ARGB32) {
+ index = VIMC_FRAME_INDEX(lin, col, vdeb->sink_fmt.width, 4);
+ vdeb->src_frame[index] = 255;
+ for (i = 0; i < 3; i++)
+ vdeb->src_frame[index + i + 1] = rgb[i];
+ } else {
+ index = VIMC_FRAME_INDEX(lin, col, vdeb->sink_fmt.width, 3);
+ for (i = 0; i < 3; i++) {
+ switch (vpix->pixelformat) {
+ case V4L2_PIX_FMT_RGB24:
+ vdeb->src_frame[index + i] = rgb[i];
+ break;
+ case V4L2_PIX_FMT_BGR24:
+ vdeb->src_frame[index + i] = rgb[2 - i];
+ break;
+ }
}
}
}
--
2.17.1
next reply other threads:[~2020-05-28 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 18:57 Kaaira Gupta [this message]
2020-05-29 15:43 ` [PATCH] vimc: debayer: Add support for ARGB format Dafna Hirschfeld
2020-06-01 12:16 ` Kaaira Gupta
2020-06-01 12:37 ` Laurent Pinchart
2020-06-01 16:27 ` Helen Koike
2020-06-02 10:52 ` Dafna Hirschfeld
2020-06-02 10:55 ` Helen Koike
2020-06-02 11:24 ` Kieran Bingham
2020-06-02 11:31 ` Helen Koike
2020-06-02 12:45 ` Laurent Pinchart
2020-06-02 13:13 ` Helen Koike
2020-06-02 13:16 ` Dafna Hirschfeld
2020-06-02 15:14 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528185717.GA20581@kaaira-HP-Pavilion-Notebook \
--to=kgupta@es.iitr.ac.in \
--cc=helen.koike@collabora.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).