archive mirror
 help / color / mirror / Atom feed
Cc:, Borislav Petkov <>,
	Mauro Carvalho Chehab <>,
	Tony Luck <>,
	James Morse <>,
	Robert Richter <>,
	Greg Kroah-Hartman <>,
	Doug Thompson <>,,
Subject: [PATCH] edac: Fix reference count leak in edac_pci_main_kobj_setup.
Date: Thu, 28 May 2020 15:22:37 -0500	[thread overview]
Message-ID: <> (raw)

From: Qiushi Wu <>

kobject_init_and_add() should be handled when it return an error,
because kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem. Thus replace calling
kfree() by calling kobject_put().

Fixes: b2ed215a3338 ("Kobject: change drivers/edac to use kobject_init_and_add")
Signed-off-by: Qiushi Wu <>
 drivers/edac/edac_pci_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/edac_pci_sysfs.c b/drivers/edac/edac_pci_sysfs.c
index 72c9eb9fdffb..53042af7262e 100644
--- a/drivers/edac/edac_pci_sysfs.c
+++ b/drivers/edac/edac_pci_sysfs.c
@@ -386,7 +386,7 @@ static int edac_pci_main_kobj_setup(void)
 	/* Error unwind statck */
-	kfree(edac_pci_top_main_kobj);
+	kobject_put(edac_pci_top_main_kobj);

             reply	other threads:[~2020-05-28 20:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 20:22 wu000273 [this message]
2020-06-17 13:56 ` [PATCH] edac: Fix reference count leak in edac_pci_main_kobj_setup Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).