From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Stephen Boyd <sboyd@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Guenter Roeck <linux@roeck-us.net>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 04/11] pwm: clps711x: Use 64-bit division macro
Date: Thu, 28 May 2020 13:33:41 -0700 [thread overview]
Message-ID: <20200528203341.GA8065@codeaurora.org> (raw)
In-Reply-To: <dd03cc467ac3fc470826aef523822b32e15dc929.1590514331.git.gurus@codeaurora.org>
On Tue, May 26, 2020 at 10:35:04AM -0700, Guru Das Srinagesh wrote:
> Since the PWM framework is switching struct pwm_args.period's datatype
> to u64, prepare for this transition by using DIV64_U64_ROUND_CLOSEST to
> handle a 64-bit divisor.
>
> Cc: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
> ---
> drivers/pwm/pwm-clps711x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-clps711x.c b/drivers/pwm/pwm-clps711x.c
> index 924d39a..ba9500a 100644
> --- a/drivers/pwm/pwm-clps711x.c
> +++ b/drivers/pwm/pwm-clps711x.c
> @@ -43,7 +43,7 @@ static void clps711x_pwm_update_val(struct clps711x_chip *priv, u32 n, u32 v)
> static unsigned int clps711x_get_duty(struct pwm_device *pwm, unsigned int v)
> {
> /* Duty cycle 0..15 max */
> - return DIV_ROUND_CLOSEST(v * 0xf, pwm->args.period);
> + return DIV64_U64_ROUND_CLOSEST(v * 0xf, pwm->args.period);
> }
>
> static int clps711x_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
> --
Hi Daniel,
Could you please review this patch when you get a chance to?
Thank you.
Guru Das.
next prev parent reply other threads:[~2020-05-28 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:35 [PATCH v15 00/11] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 01/11] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 02/11] hwmon: pwm-fan: " Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 03/11] ir-rx51: " Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 04/11] pwm: clps711x: " Guru Das Srinagesh
2020-05-28 20:33 ` Guru Das Srinagesh [this message]
2020-06-01 11:33 ` Daniel Thompson
2020-05-26 17:35 ` [PATCH v15 05/11] pwm: pwm-imx-tpm: " Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 06/11] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 07/11] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 08/11] pwm: sun4i: Use nsecs_to_jiffies to avoid a division Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 09/11] backlight: pwm_bl: Use 64-bit division function Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 10/11] clk: pwm: " Guru Das Srinagesh
2020-05-26 17:35 ` [PATCH v15 11/11] pwm: core: Convert period and duty cycle to u64 Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528203341.GA8065@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=arnd@arndb.de \
--cc=collinsd@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.thompson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).