From: Rob Herring <robh@kernel.org>
To: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
p.zabel@pengutronix.de, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andriy.shevchenko@intel.com, songjun.Wu@intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v1 1/2] Add YAML schema for a new PWM driver
Date: Thu, 28 May 2020 17:31:59 -0600 [thread overview]
Message-ID: <20200528233159.GA876777@bogus> (raw)
In-Reply-To: <53333e2a30f123065a68a3a24042ead982393164.1590132733.git.rahul.tanwar@linux.intel.com>
On Fri, May 22, 2020 at 03:41:58PM +0800, Rahul Tanwar wrote:
> Add DT bindings YAML schema for PWM controller driver of
> Lightning Mountain(LGM) SoC.
You need a better subject such as what h/w this is for. Bindings are for
h/w blocks, not drivers.
>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@linux.intel.com>
> ---
> .../devicetree/bindings/pwm/pwm-intel-lgm.yaml | 43 ++++++++++++++++++++++
Use the compatible string for filename.
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-intel-lgm.yaml
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-intel-lgm.yaml b/Documentation/devicetree/bindings/pwm/pwm-intel-lgm.yaml
> new file mode 100644
> index 000000000000..adb33265aa5e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-intel-lgm.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/pwm-intel-lgm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LGM SoC PWM controller
> +
> +maintainers:
> + - Rahul Tanwar <rahul.tanwar@intel.com>
> +
> +properties:
> + compatible:
> + const: intel,lgm-pwm
> +
> + reg:
> + maxItems: 1
> +
> + "#pwm-cells":
> + const: 2
> +
> + clocks:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - "#pwm-cells"
> + - clocks
> + - resets
additionalProperties: false
> +
> +examples:
> + - |
> + pwm: pwm@e0d00000 {
> + compatible = "intel,lgm-pwm";
> + reg = <0xe0d00000 0x30>;
> + #pwm-cells = <2>;
> + clocks = <&cgu0 126>;
> + resets = <&rcu0 0x30 21>;
> + };
> --
> 2.11.0
>
next prev parent reply other threads:[~2020-05-28 23:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 7:41 [PATCH v1 0/2] pwm: intel: Add PWM driver for new SoC Rahul Tanwar
2020-05-22 7:41 ` [PATCH v1 1/2] Add YAML schema for a new PWM driver Rahul Tanwar
2020-05-28 23:31 ` Rob Herring [this message]
2020-05-22 7:41 ` [PATCH v1 2/2] Add PWM driver for LGM Rahul Tanwar
2020-05-22 8:56 ` Uwe Kleine-König
2020-05-22 9:18 ` Andy Shevchenko
2020-05-22 9:32 ` Uwe Kleine-König
2020-05-27 6:28 ` Tanwar, Rahul
2020-05-27 9:15 ` Andy Shevchenko
2020-05-28 5:45 ` Tanwar, Rahul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528233159.GA876777@bogus \
--to=robh@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=songjun.Wu@intel.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).