From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Huacai Chen <chenhuacai@gmail.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
"open list:MIPS" <linux-mips@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS: Fix build warning about "PTR_STR" redefined under CONFIG_TEST_PRINTF
Date: Fri, 29 May 2020 09:56:43 +0200 [thread overview]
Message-ID: <20200529075643.GA7031@alpha.franken.de> (raw)
In-Reply-To: <CAAhV-H7W7iXJOmJ8yT7kfuMN2Y8VhzcOUQXrnkytEEqrQZtWmQ@mail.gmail.com>
On Fri, May 29, 2020 at 09:24:06AM +0800, Huacai Chen wrote:
> Hi, Tiezhu,
>
> On Thu, May 28, 2020 at 4:28 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> >
> > Replace PTR_STR with INST_PTR_STR to fix the following build warning when
> > CONFIG_TEST_PRINTF is set:
> >
> > CC lib/test_printf.o
> > lib/test_printf.c:214:0: warning: "PTR_STR" redefined
> > #define PTR_STR "ffff0123456789ab"
> > ^
> > In file included from ./arch/mips/include/asm/dsemul.h:11:0,
> > from ./arch/mips/include/asm/processor.h:22,
> > from ./arch/mips/include/asm/thread_info.h:16,
> > from ./include/linux/thread_info.h:38,
> > from ./include/asm-generic/preempt.h:5,
> > from ./arch/mips/include/generated/asm/preempt.h:1,
> > from ./include/linux/preempt.h:78,
> > from ./include/linux/spinlock.h:51,
> > from ./include/linux/seqlock.h:36,
> > from ./include/linux/time.h:6,
> > from ./include/linux/stat.h:19,
> > from ./include/linux/module.h:13,
> > from lib/test_printf.c:10:
> > ./arch/mips/include/asm/inst.h:20:0: note: this is the location of the previous definition
> > #define PTR_STR ".dword"
> > ^
> >
> > Fixes: e701656ec4db ("MIPS: inst.h: Stop including asm.h to avoid various build failures")
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Thank you for catching this issue, but I think this is not the best
> solution. Maciej suggest another solution, and I will send a patch to
> fix it.
thank you, I was about to fix it myself. Not sure about your plan,
but my idea would be to move the unaligned stuff into it's another
or a new header file.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-05-29 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 8:27 [PATCH] MIPS: Fix build warning about "PTR_STR" redefined under CONFIG_TEST_PRINTF Tiezhu Yang
2020-05-29 1:24 ` Huacai Chen
2020-05-29 7:56 ` Thomas Bogendoerfer [this message]
2020-05-29 8:23 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529075643.GA7031@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=chenhuacai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).