From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@stericsson.com>,
Feng Tang <feng.tang@intel.com>, Alan Cox <alan@linux.intel.com>,
Vinod Koul <vkoul@kernel.org>,
Georgy Vlasov <Georgy.Vlasov@baikalelectronics.ru>,
Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
<linux-mips@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 05/16] spi: dw: Add SPI Rx-done wait method to DMA-based transfer
Date: Fri, 29 May 2020 13:13:28 +0300 [thread overview]
Message-ID: <20200529101328.bfoyyvmwm5gfflxv@mobilestation> (raw)
In-Reply-To: <20200529094648.GY1634618@smile.fi.intel.com>
On Fri, May 29, 2020 at 12:46:48PM +0300, Andy Shevchenko wrote:
> On Fri, May 29, 2020 at 06:59:03AM +0300, Serge Semin wrote:
> > Having any data left in the Rx FIFO after the DMA engine claimed it has
> > finished all DMA transactions is an abnormal situation, since the DW SPI
> > controller driver expects to have all the data being fetched and placed
> > into the SPI Rx buffer at that moment. In case if this has happened we
> > assume that DMA engine still may be doing the data fetching, thus we give
> > it sometime to finish. If after a short period of time the data is still
> > left in the Rx FIFO, the driver will give up waiting and return an error
> > indicating that the SPI controller/DMA engine must have hung up or failed
> > at some point of doing their duties.
>
> ...
>
> > +static int dw_spi_dma_wait_rx_done(struct dw_spi *dws)
> > +{
> > + int retry = WAIT_RETRIES;
> > + struct spi_delay delay;
> > + unsigned long ns, us;
> > + u32 nents;
> > +
> > + /*
> > + * It's unlikely that DMA engine is still doing the data fetching, but
> > + * if it's let's give it some reasonable time. The timeout calculation
> > + * is based on the synchronous APB/SSI reference clock rate, on a
> > + * number of data entries left in the Rx FIFO, times a number of clock
> > + * periods normally needed for a single APB read/write transaction
> > + * without PREADY signal utilized (which is true for the DW APB SSI
> > + * controller).
> > + */
> > + nents = dw_readl(dws, DW_SPI_RXFLR);
>
> > + ns = NSEC_PER_SEC / dws->max_freq * 4 * nents;
>
> I think we may slightly increase precision by writing this like
>
> ns = 4 * NSEC_PER_SEC / dws->max_freq * nents;
Good point. Although both 4 and NSEC_PER_SEC are signed. The later is
1000000000L. Formally speaking on x32 systems (4 * 1000 000 000L) equals
to a negative value. Though overflow still won't happen so the result will
be correct. Anyway to be on a safe side it would be better to use an explicit
unsigned literal:
+ ns = 4U * NSEC_PER_SEC / dws->max_freq * nents;
-Sergey
>
>
> > + if (ns <= NSEC_PER_USEC) {
> > + delay.unit = SPI_DELAY_UNIT_NSECS;
> > + delay.value = ns;
> > + } else {
> > + us = DIV_ROUND_UP(ns, NSEC_PER_USEC);
> > + delay.unit = SPI_DELAY_UNIT_USECS;
> > + delay.value = clamp_val(us, 0, USHRT_MAX);
> > + }
> > +
> > + while (dw_spi_dma_rx_busy(dws) && retry--)
> > + spi_delay_exec(&delay, NULL);
> > +
> > + if (retry < 0) {
> > + dev_err(&dws->master->dev, "Rx hanged up\n");
> > + return -EIO;
> > + }
> > +
> > + return 0;
> > +}
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2020-05-29 10:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 3:58 [PATCH v5 00/16] spi: dw: Add generic DW DMA controller support Serge Semin
2020-05-29 3:58 ` [PATCH v5 01/16] spi: dw: Set xfer effective_speed_hz Serge Semin
2020-05-29 8:49 ` Sergei Shtylyov
2020-05-29 9:49 ` Serge Semin
2020-05-29 3:59 ` [PATCH v5 02/16] spi: dw: Return any value retrieved from the dma_transfer callback Serge Semin
2020-05-29 3:59 ` [PATCH v5 03/16] spi: dw: Locally wait for the DMA transactions completion Serge Semin
2020-05-29 7:55 ` Andy Shevchenko
2020-05-29 8:12 ` Serge Semin
2020-05-29 9:26 ` Andy Shevchenko
2020-05-29 9:56 ` Serge Semin
2020-05-29 3:59 ` [PATCH v5 04/16] spi: dw: Add SPI Tx-done wait method to DMA-based transfer Serge Semin
2020-05-29 3:59 ` [PATCH v5 05/16] spi: dw: Add SPI Rx-done " Serge Semin
2020-05-29 9:46 ` Andy Shevchenko
2020-05-29 10:13 ` Serge Semin [this message]
2020-05-29 10:20 ` Andy Shevchenko
2020-05-29 3:59 ` [PATCH v5 06/16] spi: dw: Parameterize the DMA Rx/Tx burst length Serge Semin
2020-05-29 3:59 ` [PATCH v5 07/16] spi: dw: Use DMA max burst to set the request thresholds Serge Semin
2020-05-29 3:59 ` [PATCH v5 08/16] spi: dw: Fix Rx-only DMA transfers Serge Semin
2020-05-29 3:59 ` [PATCH v5 09/16] spi: dw: Add core suffix to the DW APB SSI core source file Serge Semin
2020-05-29 3:59 ` [PATCH v5 10/16] spi: dw: Move Non-DMA code to the DW PCIe-SPI driver Serge Semin
2020-05-29 3:59 ` [PATCH v5 11/16] spi: dw: Remove DW DMA code dependency from DW_DMAC_PCI Serge Semin
2020-05-29 3:59 ` [PATCH v5 12/16] spi: dw: Add DW SPI DMA/PCI/MMIO dependency on the DW SPI core Serge Semin
2020-05-29 3:59 ` [PATCH v5 13/16] spi: dw: Cleanup generic DW DMA code namings Serge Semin
2020-05-29 3:59 ` [PATCH v5 14/16] spi: dw: Add DMA support to the DW SPI MMIO driver Serge Semin
2020-05-29 3:59 ` [PATCH v5 15/16] spi: dw: Use regset32 DebugFS method to create regdump file Serge Semin
2020-05-29 3:59 ` [PATCH v5 16/16] dt-bindings: spi: Convert DW SPI binding to DT schema Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529101328.bfoyyvmwm5gfflxv@mobilestation \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Georgy.Vlasov@baikalelectronics.ru \
--cc=Ramil.Zaripov@baikalelectronics.ru \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=feng.tang@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).