From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: 周琰杰 <zhouyanjie@wanyeetech.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, tsbogend@alpha.franken.de,
hns@goldelico.com, paul@boddie.org.uk, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, sernia.zhou@foxmail.com,
zhenwenjin@gmail.com
Subject: Re: [PATCH 1/1] dt-bindings: MIPS: Document Ingenic SoCs binding.
Date: Fri, 29 May 2020 11:39:49 -0600 [thread overview]
Message-ID: <20200529173949.GA2610526@bogus> (raw)
In-Reply-To: <H9DYAQ.4YAB8VVZPLZO@crapouillou.net>
On Tue, May 26, 2020 at 09:10:29PM +0200, Paul Cercueil wrote:
> Hi Zhou,
>
> Le mer. 27 mai 2020 à 1:07, 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> a écrit :
> > Document the available properties for the SoC root node and the
> > CPU nodes of the devicetree for the Ingenic XBurst SoCs.
> >
> > Tested-by: H. Nikolaus Schaller <hns@goldelico.com>
> > Tested-by: Paul Boddie <paul@boddie.org.uk>
> > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > ---
> > .../bindings/mips/ingenic/ingenic,cpu.yaml | 57
> > ++++++++++++++++++++++
> > 1 file changed, 57 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> > b/Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> > new file mode 100644
> > index 000000000000..afb02071a756
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mips/ingenic/ingenic,cpu.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Bindings for Ingenic XBurst family CPUs
> > +
> > +maintainers:
> > + - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
> > +
> > +description:
> > + Ingenic XBurst family CPUs shall have the following properties.
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > +
> > + - description: Ingenic XBurst®1 CPU Cores
> > + items:
>
> Strip the 'items', put the enum directly.
>
> > + enum:
> > + - ingenic,xburst-mxu1.0
> > + - ingenic,xburst-fpu1.0-mxu1.1
> > + - ingenic,xburst-fpu2.0-mxu2.0
> > +
> > + - description: Ingenic XBurst®2 CPU Cores
> > + items:
>
> Same here.
>
> > + enum:
> > + - ingenic,xburst2-fpu2.1-mxu2.1-smt
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - device_type
> > + - compatible
> > + - reg
>
> device_type is not in the list of your properties.
It doesn't have to be. There's already a schema for it in dt-schema.
It's not always required there, so requiring here is fine.
It's an oddity of json-schema, but what's listed in required doesn't
have to be in 'properties'.
Rob
prev parent reply other threads:[~2020-05-29 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:07 [PATCH 0/1] Document Ingenic SoCs binding 周琰杰 (Zhou Yanjie)
2020-05-26 17:07 ` [PATCH 1/1] dt-bindings: MIPS: " 周琰杰 (Zhou Yanjie)
2020-05-26 19:10 ` Paul Cercueil
2020-05-27 6:10 ` Zhou Yanjie
2020-05-29 17:39 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529173949.GA2610526@bogus \
--to=robh@kernel.org \
--cc=aric.pzqi@ingenic.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=sernia.zhou@foxmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).