From: Rob Herring <robh@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v4 3/4] dt-bindings: net: Add RGMII internal delay for DP83869
Date: Fri, 29 May 2020 13:03:56 -0600 [thread overview]
Message-ID: <20200529190356.GA2758033@bogus> (raw)
In-Reply-To: <20200527164934.28651-4-dmurphy@ti.com>
On Wed, May 27, 2020 at 11:49:33AM -0500, Dan Murphy wrote:
> Add the internal delay values into the header and update the binding
> with the internal delay properties.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../devicetree/bindings/net/ti,dp83869.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83869.yaml b/Documentation/devicetree/bindings/net/ti,dp83869.yaml
> index 5b69ef03bbf7..2971dd3fc039 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83869.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83869.yaml
> @@ -64,6 +64,20 @@ properties:
> Operational mode for the PHY. If this is not set then the operational
> mode is set by the straps. see dt-bindings/net/ti-dp83869.h for values
>
> + rx-internal-delay-ps:
> + $ref: "#/properties/rx-internal-delay-ps"
This just creates a circular reference which probably blows up.
> + description: Delay is in pico seconds
> + enum: [ 250, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000,
> + 3250, 3500, 3750, 4000 ]
> + default: 2000
> +
> + tx-internal-delay-ps:
> + $ref: "#/properties/tx-internal-delay-ps"
> + description: Delay is in pico seconds
> + enum: [ 250, 500, 750, 1000, 1250, 1500, 1750, 2000, 2250, 2500, 2750, 3000,
> + 3250, 3500, 3750, 4000 ]
> + default: 2000
> +
> required:
> - reg
>
> @@ -80,5 +94,7 @@ examples:
> ti,op-mode = <DP83869_RGMII_COPPER_ETHERNET>;
> ti,max-output-impedance = "true";
> ti,clk-output-sel = <DP83869_CLK_O_SEL_CHN_A_RCLK>;
> + rx-internal-delay-ps = <2000>;
> + tx-internal-delay-ps = <2000>;
> };
> };
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-29 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 16:49 [PATCH net-next v4 0/4] RGMII Internal delay common property Dan Murphy
2020-05-27 16:49 ` [PATCH net-next v4 1/4] dt-bindings: net: Add tx and rx internal delays Dan Murphy
2020-05-29 18:25 ` Rob Herring
2020-05-29 19:24 ` Dan Murphy
2020-05-29 20:58 ` Rob Herring
2020-05-27 16:49 ` [PATCH net-next v4 2/4] net: phy: Add a helper to return the index for of the internal delay Dan Murphy
2020-05-27 16:49 ` [PATCH net-next v4 3/4] dt-bindings: net: Add RGMII internal delay for DP83869 Dan Murphy
2020-05-29 19:03 ` Rob Herring [this message]
2020-05-29 19:20 ` Dan Murphy
2020-05-27 16:49 ` [PATCH net-next v4 4/4] net: dp83869: Add RGMII internal delay configuration Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529190356.GA2758033@bogus \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).