From: Wolfram Sang <wsa@the-dreams.de>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: devicetree-compiler@vger.kernel.org,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Frank Rowand <frowand.list@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] check: Add 10bit/slave i2c reg flags support
Date: Sat, 30 May 2020 11:31:52 +0200 [thread overview]
Message-ID: <20200530093152.GA1038@ninjato> (raw)
In-Reply-To: <20200527141517.22677-1-Sergey.Semin@baikalelectronics.ru>
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
> + addr = reg & 0x3FFFFFFFU;
> + snprintf(unit_addr, sizeof(unit_addr), "%x", addr);
Hmm, this hardcoded value will not work if we ever need to add another
bit. I hope this will never happen, though.
> + if ((reg & (1U << 31)) && addr > 0x3ff)
Same here with bit 31. I haven't checked DTC but can't we import the
header with the defines into the project? Or is this then a circular
dependency?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-30 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 12:25 [PATCH] check: Add 10bit/slave i2c reg flags support Serge Semin
2020-05-27 13:36 ` Andy Shevchenko
2020-05-27 14:00 ` Serge Semin
2020-05-27 14:15 ` [PATCH v2] " Serge Semin
2020-05-30 9:31 ` Wolfram Sang [this message]
2020-05-31 19:07 ` Serge Semin
2020-06-01 17:08 ` Rob Herring
2020-06-02 7:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200530093152.GA1038@ninjato \
--to=wsa@the-dreams.de \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree-compiler@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=frowand.list@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).