From: David Miller <davem@davemloft.net>
To: brgl@bgdev.pl
Cc: john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com, kuba@kernel.org,
matthias.bgg@gmail.com, broonie@kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
fparent@baylibre.com, stephane.leprovost@mediatek.com,
pedro.tsai@mediatek.com, andrew.perepech@mediatek.com,
bgolaszewski@baylibre.com
Subject: Re: [PATCH v3 0/2] regmap: provide simple bitops and use them in a driver
Date: Mon, 01 Jun 2020 11:35:36 -0700 (PDT) [thread overview]
Message-ID: <20200601.113536.134620919829517847.davem@davemloft.net> (raw)
In-Reply-To: <20200528154503.26304-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Thu, 28 May 2020 17:45:01 +0200
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> I noticed that oftentimes I use regmap_update_bits() for simple bit
> setting or clearing. In this case the fourth argument is superfluous as
> it's always 0 or equal to the mask argument.
>
> This series proposes to add simple bit operations for setting, clearing
> and testing specific bits with regmap.
>
> The second patch uses all three in a driver that got recently picked into
> the net-next tree.
>
> The patches obviously target different trees so - if you're ok with
> the change itself - I propose you pick the first one into your regmap
> tree for v5.8 and then I'll resend the second patch to add the first
> user for these macros for v5.9.
>
> v1 -> v2:
> - convert the new macros to static inline functions
>
> v2 -> v3:
> - drop unneeded ternary operator
Series applied to net-next, thank you.
next prev parent reply other threads:[~2020-06-01 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 15:45 [PATCH v3 0/2] regmap: provide simple bitops and use them in a driver Bartosz Golaszewski
2020-05-28 15:45 ` [PATCH v3 1/2] regmap: provide helpers for simple bit operations Bartosz Golaszewski
2020-05-28 15:45 ` [PATCH v3 2/2] net: ethernet: mtk-star-emac: use regmap bitops Bartosz Golaszewski
2020-05-29 16:51 ` [PATCH v3 0/2] regmap: provide simple bitops and use them in a driver Mark Brown
2020-05-29 16:57 ` Mark Brown
2020-06-01 18:35 ` David Miller [this message]
2020-06-01 18:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601.113536.134620919829517847.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew.perepech@mediatek.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=fparent@baylibre.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pedro.tsai@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=stephane.leprovost@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).