From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: [PATCH] xen: Fix build with recent suspend_hvm.c changes
Date: Mon, 1 Jun 2020 14:27:11 +0200 [thread overview]
Message-ID: <20200601122711.222696-1-vkuznets@redhat.com> (raw)
kbuild test robot reports the following issues with some randconfig build:
...
In file included from ./include/xen/interface/hvm/params.h:24,
from ./include/xen/hvm.h:6,
from arch/x86/xen/suspend_hvm.c:5:
./include/xen/interface/hvm/hvm_op.h:29:5: error: unknown type name ‘domid_t’
29 | domid_t domid; /* IN */
| ^~~~~~~
./include/xen/interface/hvm/hvm_op.h:33:1: warning: data definition has no
type or storage class
33 | DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_param);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
./include/xen/interface/hvm/hvm_op.h:33:1: error: type defaults to ‘int’ in
declaration of ‘DEFINE_GUEST_HANDLE_STRUCT’ [-Werror=implicit-int]
...
These definitions are in xen/interface/xen.h, add the include to hvm.h.
Fixes: 28447ea41542 ("xen: Move xen_setup_callback_vector() definition to include/xen/hvm.h")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
- I'm failing to see why this was compiling when 28447ea41542 ("xen: Move
xen_setup_callback_vector() definition to include/xen/hvm.h") was
submitted, just keeping playing whack-a-mole game fixing the immediate
issue, thanks kbuild robot for the report!
---
include/xen/hvm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/xen/hvm.h b/include/xen/hvm.h
index b7fd7fc9ad41..7cf0c529ab4a 100644
--- a/include/xen/hvm.h
+++ b/include/xen/hvm.h
@@ -3,6 +3,7 @@
#ifndef XEN_HVM_H__
#define XEN_HVM_H__
+#include <xen/interface/xen.h>
#include <xen/interface/hvm/params.h>
#include <asm/xen/hypercall.h>
--
2.25.4
reply other threads:[~2020-06-01 12:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601122711.222696-1-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).