From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0905C433DF for ; Mon, 1 Jun 2020 18:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE6FF20870 for ; Mon, 1 Jun 2020 18:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591037229; bh=N/W/8g3PtuuoC034RzeB9JObwXv0drfERwy505VPvqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=TARhBawk0zp0UXZcAbuXMBWE17gI+BKh9CnqfYIuGXGJ/N2b3uq5nNjsfZH6JcfWY NBf9620rbNMgBtmwONvNYlKn1MVx7iOgK7J/IznHpzs2jqTHB3FXAuIWkU92lxdFqZ ytirUyHPfyyx49DXdtfg+YNvUrlhtLbUGGOseRGE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730724AbgFASIY (ORCPT ); Mon, 1 Jun 2020 14:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:54460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730721AbgFASIV (ORCPT ); Mon, 1 Jun 2020 14:08:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E2EF62068D; Mon, 1 Jun 2020 18:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034901; bh=N/W/8g3PtuuoC034RzeB9JObwXv0drfERwy505VPvqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BbY0xG3+Gx7gudYKRr4DHRpNmZClMIEpV6I3TFnNDr3o8Yo29bVTWZSq3+Jmeen3V 9kMpTXBjb3954Lfa7PdiVWQDXqWXAMvIgXn+jAsKnNDttcl71pXvv7kOTjQhxKddNN ykK53mc1OeDVxdiZA+kNMPYlr+shXEWTY46JY+AM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Moshe Shemesh , Tariq Toukan , Saeed Mahameed Subject: [PATCH 5.4 023/142] net/mlx5: Fix memory leak in mlx5_events_init Date: Mon, 1 Jun 2020 19:53:01 +0200 Message-Id: <20200601174040.228790262@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174037.904070960@linuxfoundation.org> References: <20200601174037.904070960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Moshe Shemesh [ Upstream commit df14ad1eccb04a4a28c90389214dbacab085b244 ] Fix memory leak in mlx5_events_init(), in case create_single_thread_workqueue() fails, events struct should be freed. Fixes: 5d3c537f9070 ("net/mlx5: Handle event of power detection in the PCIE slot") Signed-off-by: Moshe Shemesh Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/events.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlx5/core/events.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/events.c @@ -346,8 +346,10 @@ int mlx5_events_init(struct mlx5_core_de events->dev = dev; dev->priv.events = events; events->wq = create_singlethread_workqueue("mlx5_events"); - if (!events->wq) + if (!events->wq) { + kfree(events); return -ENOMEM; + } INIT_WORK(&events->pcie_core_work, mlx5_pcie_event); return 0;