From: Bob Haarman <inglorion@google.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <ak@linux.intel.com>,
Fangrui Song <maskray@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
stable@vger.kernel.org,
Nathan Chancellor <natechancellor@gmail.com>,
Alistair Delva <adelva@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Kyung Min Park <kyung.min.park@intel.com>,
afzal mohammed <afzal.mohd.ma@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Kees Cook <keescook@chromium.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Dave Hansen <dave.hansen@intel.com>, Baoquan He <bhe@redhat.com>,
Thomas Lendacky <Thomas.Lendacky@amd.com>,
Ross Zwisler <zwisler@chromium.org>,
Arvind Sankar <nivedita@alum.mit.edu>,
Dmitry Safonov <0x7f454c46@gmail.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] x86_64: fix jiffies ODR violation
Date: Mon, 1 Jun 2020 16:47:56 -0700 [thread overview]
Message-ID: <20200601234756.GA10511@google.com> (raw)
In-Reply-To: <20200519031742.GB499505@tassilo.jf.intel.com>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On Mon, May 18, 2020 at 08:17:42PM -0700, Andi Kleen wrote:
> > Instead, we can avoid the ODR violation by matching other arch's by
> > defining jiffies only by linker script. For -fno-semantic-interposition
> > + Full LTO, there is no longer a global definition of jiffies for the
> > compiler to produce a local symbol which the linker script won't ensure
> > aliases to jiffies_64.
>
> I guess it was an historical accident.
>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
Thank you, Andi. Do any other reviewers have comments?
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3856 bytes --]
next prev parent reply other threads:[~2020-06-01 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 18:05 [PATCH] x86_64: fix jiffies ODR violation Bob Haarman
2020-05-19 3:17 ` Andi Kleen
2020-06-01 23:47 ` Bob Haarman [this message]
2020-06-02 13:27 ` Josh Poimboeuf
2020-06-02 19:30 ` [PATCH v2] " Bob Haarman
2020-06-04 7:30 ` Sedat Dilek
2020-06-09 8:53 ` [tip: x86/urgent] x86_64: Fix " tip-bot2 for Bob Haarman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601234756.GA10511@google.com \
--to=inglorion@google.com \
--cc=0x7f454c46@gmail.com \
--cc=Thomas.Lendacky@amd.com \
--cc=adelva@google.com \
--cc=afzal.mohd.ma@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=dave.hansen@intel.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kyung.min.park@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maskray@google.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=nivedita@alum.mit.edu \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=x86@kernel.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).