From: Alexander Gordeev <agordeev@linux.ibm.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-s390@vger.kernel.org, Stable <stable@vger.kernel.org>,
Yury Norov <yury.norov@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Amritha Nambiar <amritha.nambiar@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
Kees Cook <keescook@chromium.org>,
Matthew Wilcox <willy@infradead.org>,
Miklos Szeredi <mszeredi@redhat.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Steffen Klassert <steffen.klassert@secunet.com>,
"Tobin C . Harding" <tobin@kernel.org>,
Vineet Gupta <vineet.gupta1@synopsys.com>,
Will Deacon <will.deacon@arm.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs
Date: Tue, 2 Jun 2020 12:24:31 +0200 [thread overview]
Message-ID: <20200602102430.GA17703@oc3871087118.ibm.com> (raw)
In-Reply-To: <20200518115059.GA19150@oc3871087118.ibm.com>
On Mon, May 18, 2020 at 01:50:59PM +0200, Alexander Gordeev wrote:
> On Mon, May 18, 2020 at 02:33:43PM +0300, Andy Shevchenko wrote:
> > On Mon, May 18, 2020 at 1:40 PM Alexander Gordeev
> > <agordeev@linux.ibm.com> wrote:
> > >
> > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does
> > > not take into account order of halfwords on 64-bit big
> > > endian architectures.
> >
> > Thanks for report and the patch!
> >
> > Did it work before? Can we have a test case for that that we will see
> > the failure?
>
> The test exists and enabled with CONFIG_TEST_BITMAP.
> It does not appear ever passed before on 64 BE.
> It does not fail on 64 LE for me either.
Hi Andy et al,
Any feedback on the fix? Does it work on 64 LE for you?
Thanks!
> Thanks!
>
> [...]
>
> > --
> > With Best Regards,
> > Andy Shevchenko
next prev parent reply other threads:[~2020-06-02 10:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 10:34 [PATCH RESEND] lib: fix bitmap_parse() on 64-bit big endian archs Alexander Gordeev
2020-05-18 11:33 ` Andy Shevchenko
2020-05-18 11:35 ` Andy Shevchenko
2020-05-18 11:51 ` Alexander Gordeev
2020-06-02 10:24 ` Alexander Gordeev [this message]
2020-06-05 13:25 ` Andy Shevchenko
2020-06-08 10:28 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602102430.GA17703@oc3871087118.ibm.com \
--to=agordeev@linux.ibm.com \
--cc=acme@redhat.com \
--cc=amritha.nambiar@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mszeredi@redhat.com \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tobin@kernel.org \
--cc=vineet.gupta1@synopsys.com \
--cc=will.deacon@arm.com \
--cc=willemb@google.com \
--cc=willy@infradead.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).