From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
Jin Yao <yao.jin@linux.intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCHv3] perf stat: Ensure group is defined on top of the same cpu mask
Date: Tue, 2 Jun 2020 17:28:06 +0200 [thread overview]
Message-ID: <20200602152806.GD1169993@krava> (raw)
In-Reply-To: <20200602150352.GS31795@kernel.org>
On Tue, Jun 02, 2020 at 12:03:52PM -0300, Arnaldo Carvalho de Melo wrote:
SNIP
> > right, it disables 'grouping', events are scheduled/counted individualy
>
> Ok, I applied this already, we can fix this in the next cycle.
>
> > this way we will not hit the issue when looking for group_fd FD
> > and there's not any, because of different cpu maps
>
> > > If I do:
>
> > > [root@seventh ~]# perf stat -e '{power/energy-cores/,power/energy-ram/},{instructions,cycles}' -a sleep 2
>
> > > Performance counter stats for 'system wide':
>
> > > 1.73 Joules power/energy-cores/
> > > 0.92 Joules power/energy-ram/
> > > 12,191,658 instructions # 0.67 insn per cycles/
> > > 18,275,233 cycles
>
> > > 2.001272492 seconds time elapsed
>
> > > [root@seventh ~]#
> > >
> > > It works, grouped. One observation, shouldn't we somehow show in the
> > > output that the first two were indeed grouped, ditto for the second two?
>
> > yea, we don't display groups in output.. also there's no number
> > for the group, it's still separate events numbers in output
> > grouping is only used when creating events
>
> perhaps if we just add a blank line to separate groups? I.e. the above
> would be:
>
> [root@seventh ~]# perf stat -e '{power/energy-cores/,power/energy-ram/},{instructions,cycles}' -a sleep 2
>
> Performance counter stats for 'system wide':
>
> 1.73 Joules power/energy-cores/
> 0.92 Joules power/energy-ram/
>
> 12,191,658 instructions # 0.67 insn per cycle
> 18,275,233 cycles
>
> 2.001272492 seconds time elapsed
maybe it could be separated by new line and we could put note in the comment:
Performance counter stats for 'system wide':
1.73 Joules power/energy-cores/
0.92 Joules power/energy-ram/ # groupped
12,191,658 instructions # 0.67 insn per cycle
18,275,233 cycles
2.001272492 seconds time elapsed
for events that already have defined comment, it'd be on the next line, like:
Performance counter stats for 'system wide':
1.73 Joules power/energy-cores/
0.92 Joules power/energy-ram/ # XXXXX
# groupped
12,191,658 instructions # 0.67 insn per cycle
18,275,233 cycles
2.001272492 seconds time elapsed
jirka
next prev parent reply other threads:[~2020-06-02 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 16:22 [PATCH] perf stat: Ensure group is defined on top of the same cpu mask Jiri Olsa
2020-06-01 0:04 ` Ian Rogers
2020-06-01 7:40 ` Jiri Olsa
2020-06-01 8:15 ` Jiri Olsa
2020-06-01 8:20 ` [PATCHv2] " Jiri Olsa
2020-06-01 16:20 ` Ian Rogers
2020-06-02 2:47 ` Namhyung Kim
2020-06-02 8:15 ` Jiri Olsa
2020-06-02 11:50 ` Namhyung Kim
2020-06-02 12:10 ` Jiri Olsa
2020-06-02 13:25 ` Arnaldo Carvalho de Melo
2020-06-02 10:17 ` [PATCHv3] " Jiri Olsa
2020-06-02 13:42 ` Arnaldo Carvalho de Melo
2020-06-02 14:05 ` Jiri Olsa
2020-06-02 15:03 ` Arnaldo Carvalho de Melo
2020-06-02 15:28 ` Jiri Olsa [this message]
2020-06-02 15:48 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602152806.GD1169993@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).