From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1EAC433E0 for ; Tue, 2 Jun 2020 23:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85EEA20663 for ; Tue, 2 Jun 2020 23:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbgFBXoj (ORCPT ); Tue, 2 Jun 2020 19:44:39 -0400 Received: from mail.baikalelectronics.com ([87.245.175.226]:57864 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgFBXoj (ORCPT ); Tue, 2 Jun 2020 19:44:39 -0400 Received: from localhost (unknown [127.0.0.1]) by mail.baikalelectronics.ru (Postfix) with ESMTP id 739AD8030808; Tue, 2 Jun 2020 23:44:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at baikalelectronics.ru Received: from mail.baikalelectronics.ru ([127.0.0.1]) by localhost (mail.baikalelectronics.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vYqbvJLx9H0f; Wed, 3 Jun 2020 02:44:35 +0300 (MSK) Date: Wed, 3 Jun 2020 02:44:34 +0300 From: Serge Semin To: Lars Povlsen List-Id: CC: Serge Semin , Mark Brown , SoC Team , , , , Microchip Linux Driver Support , Subject: Re: [PATCH 00/10] spi: Adding support for Microchip Sparx5 SoC Message-ID: <20200602234434.tznhbtt3sgpz5lxz@mobilestation> References: <20200513140031.25633-1-lars.povlsen@microchip.com> <20200529162130.hsjcde27xhohl6jl@mobilestation> <87img9q3sb.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87img9q3sb.fsf@soft-dev15.microsemi.net> X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 02, 2020 at 10:18:28AM +0200, Lars Povlsen wrote: > > Serge Semin writes: > > > Hello Lars, > > > > On Wed, May 13, 2020 at 04:00:21PM +0200, Lars Povlsen wrote: > >> This is an add-on series to the main SoC Sparx5 series > >> (Message-ID: <20200513125532.24585-1-lars.povlsen@microchip.com>). > >> > >> The series add support for Sparx5 on top of the existing > >> ocelot/jaguar2 spi driver. > >> > >> It spins off the existing support for the MSCC platforms into a > >> separate driver, as adding new platforms from the MSCC/Microchip > >> product lines will further complicate (clutter) the original driver. > >> > >> New YAML dt-bindings are provided for the resulting driver. > >> > >> It is expected that the DT patches are to be taken directly by the arm-soc > >> maintainers. > > > > Regarding our cooperation. It can be implemented as follows. Since your patchset > > is less cumbersome than mine and is more ready to be integrated into the generic DW > > APB SSI code, it would be better to first make it through Mark', Andy' and my reviews > > to be further merged into the kernel version of the driver. After that I'll have > > my code altered so it could be applied on top of your patches. When everything > > is done we'll have a more comprehensive DW APB SSI driver with poll-based > > PIO operations support, new features like rx-delay, etc. > > > > Hi Serge! > > I think I would be able to work on the SPI patches this week. Should I > base it on the current spi-next or 5.7? Then address the comments and > send out a new revision? Finally I've done a part of review. It must be enough for v2. As Mark said the new version is supposed to be based on the spi-next, since that branch's got all recent DW APB SSI patches applied. -Sergey > > Thanks for reaching out. > > ---Lars > > > Thank you one more time for the series you've shared with us. Let's see what can > > be done to improve it... > > > > -Sergey > > > >> > >> Lars Povlsen (10): > >> spi: dw: Add support for polled operation via no IRQ specified in DT > >> spi: dw: Add support for RX sample delay register > >> spi: dw: Add support for client driver memory operations > >> dt-bindings: spi: Add bindings for spi-dw-mchp > >> spi: spi-dw-mmio: Spin off MSCC platforms into spi-dw-mchp > >> dt-bindings: spi: spi-dw-mchp: Add Sparx5 support > >> spi: spi-dw-mchp: Add Sparx5 support > >> arm64: dts: sparx5: Add SPI controller > >> arm64: dts: sparx5: Add spi-nor support > >> arm64: dts: sparx5: Add spi-nand devices > >> > >> .../bindings/spi/mscc,ocelot-spi.yaml | 89 ++++ > >> .../bindings/spi/snps,dw-apb-ssi.txt | 7 +- > >> MAINTAINERS | 2 + > >> arch/arm64/boot/dts/microchip/sparx5.dtsi | 37 ++ > >> .../boot/dts/microchip/sparx5_pcb125.dts | 16 + > >> .../boot/dts/microchip/sparx5_pcb134.dts | 22 + > >> .../dts/microchip/sparx5_pcb134_board.dtsi | 9 + > >> .../boot/dts/microchip/sparx5_pcb135.dts | 23 + > >> .../dts/microchip/sparx5_pcb135_board.dtsi | 9 + > >> arch/mips/configs/generic/board-ocelot.config | 2 +- > >> drivers/spi/Kconfig | 7 + > >> drivers/spi/Makefile | 1 + > >> drivers/spi/spi-dw-mchp.c | 399 ++++++++++++++++++ > >> drivers/spi/spi-dw-mmio.c | 93 ---- > >> drivers/spi/spi-dw.c | 31 +- > >> drivers/spi/spi-dw.h | 4 + > >> 16 files changed, 644 insertions(+), 107 deletions(-) > >> create mode 100644 Documentation/devicetree/bindings/spi/mscc,ocelot-spi.yaml > >> create mode 100644 drivers/spi/spi-dw-mchp.c > >> > >> -- > >> 2.26.2 > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > -- > Lars Povlsen, > Microchip