* [PATCH 04/15] ahci: use PCI_IRQ_MSI_TYPES where appropriate
@ 2020-06-02 9:20 Piotr Stankiewicz
2020-06-03 5:15 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Piotr Stankiewicz @ 2020-06-02 9:20 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-ide, linux-kernel, Piotr Stankiewicz
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
drivers/ata/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 0c0a736eb861..ca1bf4ef0f17 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -1556,7 +1556,7 @@ static int ahci_init_msi(struct pci_dev *pdev, unsigned int n_ports,
*/
if (n_ports > 1) {
nvec = pci_alloc_irq_vectors(pdev, n_ports, INT_MAX,
- PCI_IRQ_MSIX | PCI_IRQ_MSI);
+ PCI_IRQ_MSI_TYPES);
if (nvec > 0) {
if (!(readl(hpriv->mmio + HOST_CTL) & HOST_MRSM)) {
hpriv->get_irq_vector = ahci_get_irq_vector;
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 04/15] ahci: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 9:20 [PATCH 04/15] ahci: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
@ 2020-06-03 5:15 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2020-06-03 5:15 UTC (permalink / raw)
To: Piotr Stankiewicz; +Cc: Jens Axboe, linux-ide, linux-kernel
On Tue, Jun 02, 2020 at 11:20:12AM +0200, Piotr Stankiewicz wrote:
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
>
> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Im not sure where PCI_IRQ_MSI_TYPES appeared (I can't find it in
mainline), but I think replacing the supported list of types with this
weird group is no in any way a good idea.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-03 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 9:20 [PATCH 04/15] ahci: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-03 5:15 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).