From: "Ahmed S. Darwish" <a.darwish@linutronix.de>
To: Hillf Danton <hdanton@sina.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH] mm: swap: remove lru drain waiters
Date: Wed, 3 Jun 2020 12:24:12 +0200 [thread overview]
Message-ID: <20200603102412.GA1030128@debian-buster-darwi.lab.linutronix.de> (raw)
In-Reply-To: <20200603082145.jfgmzozx42rjxegx@linutronix.de>
Hi Hillf,
For some reason, **all of your posts** from <hdanton@sina.com> do not
appear on lore.kernel.org.
Check, for example, https://lore.kernel.org/lkml/?q=hdanton%40sina.com,
where thread replies are there but not the actual posts.
Just wanted to let you know... Please continue below.
On Wed, Jun 03, 2020 at 10:21:45AM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-06-01 22:37:34 [+0800], Hillf Danton wrote:
> >
> > After updating the lru drain sequence, new comers avoid waiting for
> > the current drainer, because he is flushing works on each online CPU,
> > by trying to lock the mutex; the drainer OTOH tries to do works for
> > those who fail to acquire the lock by checking the lru drain sequence
> > after releasing lock.
> >
> > See eef1a429f234 ("mm/swap.c: piggyback lru_add_drain_all() calls")
> > for reasons why we can skip waiting for the lock.
> >
> > The memory barriers around the sequence and the lock come together
> > to remove waiters without their drain works bandoned.
> >
> > Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> > Signed-off-by: Hillf Danton <hdanton@sina.com>
> > ---
> > This is inspired by one of the works from Sebastian.
>
> Not me, it was Ahmed.
>
> > --- a/mm/swap.c
> > +++ b/mm/swap.c
> > @@ -714,10 +714,11 @@ static void lru_add_drain_per_cpu(struct
> > */
> > void lru_add_drain_all(void)
> > {
> > - static seqcount_t seqcount = SEQCNT_ZERO(seqcount);
> > + static unsigned int lru_drain_seq;
> > static DEFINE_MUTEX(lock);
> > static struct cpumask has_work;
> > - int cpu, seq;
> > + int cpu;
> > + unsigned int seq;
> >
> > /*
> > * Make sure nobody triggers this path before mm_percpu_wq is fully
> > @@ -726,18 +727,16 @@ void lru_add_drain_all(void)
> > if (WARN_ON(!mm_percpu_wq))
> > return;
> >
> > - seq = raw_read_seqcount_latch(&seqcount);
> > + lru_drain_seq++;
> > + smp_mb();
> >
> > - mutex_lock(&lock);
> > +more_work:
> >
> > - /*
> > - * Piggyback on drain started and finished while we waited for lock:
> > - * all pages pended at the time of our enter were drained from vectors.
> > - */
> > - if (__read_seqcount_retry(&seqcount, seq))
> > - goto done;
> > + if (!mutex_trylock(&lock))
> > + return;
> >
The patch I've posted makes sure to preserve the existing draining
logic. It only fixes an erroneous usage of seqcount_t latching, plus a
memory barriers bugfix, found by John, and is to be included in v2:
https://lkml.kernel.org/r/87y2pg9erj.fsf@vostro.fn.ogness.net
On the other hand, you're making the draining operation completely
asynchronous for a number of callers. This is such a huge change, and I
fail to see: 1) any rationale for it in the changelog, 2) whether it's
been verified that call-sites won't be affected.
Thanks,
--
Ahmed S. Darwish
Linutronix GmbH
prev parent reply other threads:[~2020-06-03 10:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200601143734.9572-1-hdanton@sina.com>
2020-06-01 15:41 ` [RFC PATCH] mm: swap: remove lru drain waiters Konstantin Khlebnikov
2020-06-03 8:21 ` Sebastian Andrzej Siewior
2020-06-03 10:24 ` Ahmed S. Darwish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603102412.GA1030128@debian-buster-darwi.lab.linutronix.de \
--to=a.darwish@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=hdanton@sina.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).