From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F46C433DF for ; Wed, 3 Jun 2020 11:48:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07DA420674 for ; Wed, 3 Jun 2020 11:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726217AbgFCLsZ (ORCPT ); Wed, 3 Jun 2020 07:48:25 -0400 Received: from mga05.intel.com ([192.55.52.43]:60814 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgFCLsY (ORCPT ); Wed, 3 Jun 2020 07:48:24 -0400 IronPort-SDR: MPFyheC/1UhhEtAUid5w3x2OQUY4lZiupPVAL0JUo9EEBKYon6DRzzFNtrdyE/3B2O6ABTNHgh cvsbalSIkSBg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 04:48:24 -0700 IronPort-SDR: zUZHYsd0TDlM9cjrE/FJRPZRRO6pKkaLB9JY2BX8SQQR/Cs5KfnFghUZP+qXjqZUGRtKTtvHYf zHqlyGvDBLeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,467,1583222400"; d="scan'208";a="269051814" Received: from gklab-125-110.igk.intel.com ([10.91.125.110]) by orsmga003.jf.intel.com with ESMTP; 03 Jun 2020 04:48:21 -0700 From: Piotr Stankiewicz To: Bjorn Helgaas , linux-pci@vger.kernel.org Cc: Piotr Stankiewicz , Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Arnd Bergmann , Andy Shevchenko , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/15] IB/qib: Use PCI_IRQ_MSI_TYPES where appropriate Date: Wed, 3 Jun 2020 13:48:17 +0200 Message-Id: <20200603114819.13377-1-piotr.stankiewicz@intel.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20200603114212.12525-1-piotr.stankiewicz@intel.com> References: <20200603114212.12525-1-piotr.stankiewicz@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Seeing as there is shorthand available to use when asking for any type of interrupt, or any type of message signalled interrupt, leverage it. Signed-off-by: Piotr Stankiewicz Reviewed-by: Andy Shevchenko --- drivers/infiniband/hw/qib/qib_pcie.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c index 3dc6ce033319..caff44d2c12c 100644 --- a/drivers/infiniband/hw/qib/qib_pcie.c +++ b/drivers/infiniband/hw/qib/qib_pcie.c @@ -213,7 +213,7 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent) u16 linkstat, speed; int nvec; int maxvec; - unsigned int flags = PCI_IRQ_MSIX | PCI_IRQ_MSI; + unsigned int flags; if (!pci_is_pcie(dd->pcidev)) { qib_dev_err(dd, "Can't find PCI Express capability!\n"); @@ -225,7 +225,9 @@ int qib_pcie_params(struct qib_devdata *dd, u32 minw, u32 *nent) } if (dd->flags & QIB_HAS_INTX) - flags |= PCI_IRQ_LEGACY; + flags = PCI_IRQ_ALL_TYPES; + else + flags = PCI_IRQ_MSI_TYPES; maxvec = (nent && *nent) ? *nent : 1; nvec = pci_alloc_irq_vectors(dd->pcidev, 1, maxvec, flags); if (nvec < 0) -- 2.17.2