From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A76CC433E1 for ; Wed, 3 Jun 2020 14:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C0C9206E6 for ; Wed, 3 Jun 2020 14:31:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="K3SjXSpb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726026AbgFCO3s (ORCPT ); Wed, 3 Jun 2020 10:29:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgFCO3r (ORCPT ); Wed, 3 Jun 2020 10:29:47 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F05F3C08C5C1 for ; Wed, 3 Jun 2020 07:29:46 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id h5so2602984wrc.7 for ; Wed, 03 Jun 2020 07:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GHOI3hCq0wQbV5uWu698h1xL8vD8BAsADvtP/YAEZbY=; b=K3SjXSpb5L8l4YP9xtBId4+HzVpdbm6fhCiZ/5+kS5ESbrxo3dVjsqqPwtXM7X4bHk gT6D6Ox4RZjNjk9mD11ZHIF0TYsDYYS/VBM3kTr/TA0igf8xYMZWOluYylJh4EOaP7sY scfunH4GqH4dwKwcCan2OWfau1mLe6zjh9NTKYUf/SAHKAwY2MXHxEk1qMOiP0QH/ZHm FPIMx5+tj2BnzCQ2W0FAP/vLLYerOQ/TJa0aJTOu+BH71S395YnzjUCp6ioHpUmVkIjQ /ScputRXvPrmjTt6QNcXVPsBTWKgblPZ8EAiPj8RpqdSltoPoRfoco/wRW91Hm8peCMu UN2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GHOI3hCq0wQbV5uWu698h1xL8vD8BAsADvtP/YAEZbY=; b=VjuoWpYOuieF0/qUqBrG1y9rKyUhgMZwfTiJPmiUipzx9sdX+DulU/ejoPIdY/YNzQ ZSNPIJwkraTyFLQvHasGbbrKaSxwauYS4PGVVN/hxoxx1QGLULhdwtbikIQO914yVOm1 zr4YbS0ViOfPQWpbzVfJx98XHD8pZNVsXARxXX62Kyic0gYN4iE+lgD7puohD7Fk5R2Q sSIU9zW7tYVMFqTWSsERQUB86bdnbKTxQjKvviPsS5tRGXoa33z/SWvfYsA6Mu00zjpg SSDKDcPqz4wH9CkQ7iBpQ3LfGCBACLWqZIUvfVf2ySr/q7OEIXD93YYUDEzyGM5VYSCl yaKQ== X-Gm-Message-State: AOAM533iY19/RlMdJ/9+8IJ0FcNqenRb2CkpzynzjFnJynJcg1IPEDH4 ms4paxuUXR2XfZVNnyR3q9fVr+Gl1Fw= X-Google-Smtp-Source: ABdhPJzdS2IsuE71otq0TIhWvAuDdtVc0MbnYqWh+BBsP1ENSHdsYb//XredkWAlgwzhoJd7cr+qDw== X-Received: by 2002:a5d:604b:: with SMTP id j11mr31054657wrt.193.1591194585511; Wed, 03 Jun 2020 07:29:45 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id o6sm3732960wrp.3.2020.06.03.07.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2020 07:29:44 -0700 (PDT) Date: Wed, 3 Jun 2020 16:29:44 +0200 From: Jiri Pirko To: Vadym Kochan Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , Ido Schimmel , Andrew Lunn , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , Andrii Savka , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mickey Rachamim Subject: Re: [net-next 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices Message-ID: <20200603142944.GA5892@nanopsycho.orion> References: <20200528151245.7592-1-vadym.kochan@plvision.eu> <20200528151245.7592-2-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200528151245.7592-2-vadym.kochan@plvision.eu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, May 28, 2020 at 05:12:40PM CEST, vadym.kochan@plvision.eu wrote: [...] >+static int prestera_port_create(struct prestera_switch *sw, u32 id) >+{ >+ struct prestera_port *port; >+ struct net_device *dev; >+ int err; >+ >+ dev = alloc_etherdev(sizeof(*port)); >+ if (!dev) >+ return -ENOMEM; >+ >+ port = netdev_priv(dev); >+ >+ port->dev = dev; >+ port->id = id; >+ port->sw = sw; >+ >+ err = prestera_hw_port_info_get(port, &port->fp_id, >+ &port->hw_id, &port->dev_id); >+ if (err) { >+ dev_err(prestera_dev(sw), "Failed to get port(%u) info\n", id); >+ goto err_port_init; >+ } >+ >+ dev->features |= NETIF_F_NETNS_LOCAL; >+ dev->netdev_ops = &netdev_ops; >+ >+ netif_carrier_off(dev); No need.