From: Kees Cook <keescook@chromium.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Alexander Potapenko <glider@google.com>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
x86@kernel.org, drbd-dev@lists.linbit.com,
linux-block@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-ide@vger.kernel.org, linux-clk@vger.kernel.org,
linux-spi@vger.kernel.org, linux-mm@kvack.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH 09/10] treewide: Remove uninitialized_var() usage
Date: Wed, 3 Jun 2020 21:02:31 -0700 [thread overview]
Message-ID: <202006032048.E7B1D18A1@keescook> (raw)
In-Reply-To: <20200604033315.GA1131596@ubuntu-n2-xlarge-x86>
On Wed, Jun 03, 2020 at 08:33:15PM -0700, Nathan Chancellor wrote:
> On Wed, Jun 03, 2020 at 04:32:02PM -0700, Kees Cook wrote:
> > Using uninitialized_var() is dangerous as it papers over real bugs[1]
> > (or can in the future), and suppresses unrelated compiler warnings
> > (e.g. "unused variable"). If the compiler thinks it is uninitialized,
> > either simply initialize the variable or make compiler changes.
> >
> > I preparation for removing[2] the[3] macro[4], remove all remaining
> > needless uses with the following script:
> >
> > git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \
> > xargs perl -pi -e \
> > 's/\buninitialized_var\(([^\)]+)\)/\1/g;
> > s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;'
> >
> > drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid
> > pathological white-space.
> >
> > No outstanding warnings were found building allmodconfig with GCC 9.3.0
> > for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64,
> > alpha, and m68k.
> >
> > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
> > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
> > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
> > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> <snip>
>
> > diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c
> > index a0f6813f4560..a71fa7204882 100644
> > --- a/arch/powerpc/kvm/book3s_pr.c
> > +++ b/arch/powerpc/kvm/book3s_pr.c
> > @@ -1829,7 +1829,7 @@ static int kvmppc_vcpu_run_pr(struct kvm_run *kvm_run, struct kvm_vcpu *vcpu)
> > {
> > int ret;
> > #ifdef CONFIG_ALTIVEC
> > - unsigned long uninitialized_var(vrsave);
> > + unsigned long vrsave;
> > #endif
>
> This variable is actually unused:
>
> ../arch/powerpc/kvm/book3s_pr.c:1832:16: warning: unused variable 'vrsave' [-Wunused-variable]
> unsigned long vrsave;
> ^
> 1 warning generated.
>
> It has been unused since commit 99dae3bad28d ("KVM: PPC: Load/save
> FP/VMX/VSX state directly to/from vcpu struct").
>
> $ git grep vrsave 99dae3bad28d8fdd32b7bfdd5e2ec7bb2d4d019d arch/powerpc/kvm/book3s_pr.c
> 99dae3bad28d8fdd32b7bfdd5e2ec7bb2d4d019d:arch/powerpc/kvm/book3s_pr.c: unsigned long uninitialized_var(vrsave);
>
> I would nuke the whole '#ifdef' block.
Ah, thanks! I wonder why I don't have CONFIG_ALTIVEC in any of my ppc
builds. Hmmm.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2020-06-04 4:02 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 23:31 [PATCH 00/10] Remove uninitialized_var() macro Kees Cook
2020-06-03 23:31 ` [PATCH 01/10] x86/mm/numa: Remove uninitialized_var() usage Kees Cook
2020-06-04 7:58 ` Thomas Gleixner
2020-06-04 11:41 ` Miguel Ojeda
2020-06-04 14:56 ` Kees Cook
2020-06-04 15:22 ` Miguel Ojeda
2020-06-04 14:34 ` Kees Cook
2020-06-04 21:39 ` Thomas Gleixner
2020-06-04 22:39 ` Kees Cook
2020-06-03 23:31 ` [PATCH 02/10] drbd: " Kees Cook
2020-06-04 19:56 ` Nick Desaulniers
2020-06-03 23:31 ` [PATCH 03/10] b43: " Kees Cook
2020-06-04 20:08 ` Nick Desaulniers
2020-06-04 20:18 ` Kees Cook
2020-06-04 20:25 ` Nick Desaulniers
2020-06-05 9:20 ` Kalle Valo
2020-06-03 23:31 ` [PATCH 04/10] rtlwifi: rtl8192cu: " Kees Cook
2020-06-04 20:16 ` Nick Desaulniers
2020-06-05 9:18 ` Kalle Valo
2020-06-03 23:31 ` [PATCH 05/10] ide: " Kees Cook
2020-06-04 19:29 ` Nick Desaulniers
2020-06-04 20:20 ` Kees Cook
2020-06-04 20:29 ` Nick Desaulniers
2020-06-15 19:32 ` Kees Cook
2020-06-04 20:58 ` Sedat Dilek
2020-06-03 23:31 ` [PATCH 06/10] clk: st: " Kees Cook
2020-06-04 4:38 ` Stephen Boyd
2020-06-03 23:32 ` [PATCH 07/10] spi: davinci: " Kees Cook
2020-06-04 19:40 ` Nick Desaulniers
2020-06-03 23:32 ` [PATCH 08/10] checkpatch: Remove awareness of uninitialized_var() macro Kees Cook
2020-06-04 0:02 ` Joe Perches
2020-06-04 1:40 ` Kees Cook
2020-06-04 1:47 ` Joe Perches
2020-06-04 2:44 ` Kees Cook
2020-06-04 2:53 ` Sedat Dilek
2020-06-04 3:46 ` Kees Cook
2020-06-03 23:32 ` [PATCH 09/10] treewide: Remove uninitialized_var() usage Kees Cook
2020-06-04 3:33 ` Nathan Chancellor
2020-06-04 4:02 ` Kees Cook [this message]
2020-06-04 10:45 ` Leon Romanovsky
2020-06-04 13:23 ` Jason Gunthorpe
2020-06-04 14:59 ` Kees Cook
2020-06-04 17:57 ` Jason Gunthorpe
2020-06-04 19:09 ` Geert Uytterhoeven
2020-06-05 9:25 ` Kalle Valo
2020-06-03 23:32 ` [PATCH 10/10] compiler: Remove uninitialized_var() macro Kees Cook
2020-06-04 0:00 ` Bart Van Assche
2020-06-04 0:50 ` Miguel Ojeda
2020-06-04 1:23 ` [PATCH 00/10] " Sedat Dilek
2020-06-04 1:44 ` Kees Cook
2020-06-04 1:46 ` Sedat Dilek
2020-06-04 3:33 ` Nathan Chancellor
2020-06-04 7:26 ` Sedat Dilek
2020-06-04 14:27 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006032048.E7B1D18A1@keescook \
--to=keescook@chromium.org \
--cc=apw@canonical.com \
--cc=b43-dev@lists.infradead.org \
--cc=clang-built-linux@googlegroups.com \
--cc=drbd-dev@lists.linbit.com \
--cc=glider@google.com \
--cc=joe@perches.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).