From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=TsDl=7R=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D8D1DC433E0
	for <linux-kernel@archiver.kernel.org>; Thu,  4 Jun 2020 01:01:13 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id ACEB120679
	for <linux-kernel@archiver.kernel.org>; Thu,  4 Jun 2020 01:01:13 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="JuXnc4Ix"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730556AbgFDBBM (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 3 Jun 2020 21:01:12 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:35668 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1730536AbgFDBBL (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 Jun 2020 21:01:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=qgig+QxxR7tPUl/kgxOiJyYJNdXdDbQx8cvEheiz77E=; b=JuXnc4Ix6ThrhF8KQYwgDcCUPc
        G+0U/tE9RGfPTNKOlLp90SorYLvbKThHUywkJIh99TyKQcF6AiuimcAamPs0GAaoPHVjAas9R4ca0
        DnnS3PBL7zG6AEacjqNwrIjP5QaDPAzLF2PUq1rjvtLpspYj+VjHw2cSJJzbJTjY2Qxg=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.93)
        (envelope-from <andrew@lunn.ch>)
        id 1jgeFj-0046MS-1L; Thu, 04 Jun 2020 03:01:03 +0200
Date:   Thu, 4 Jun 2020 03:01:03 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Roelof Berg <rberg@berg-solutions.de>
Cc:     Bryan Whitehead <bryan.whitehead@microchip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit
 speed
Message-ID: <20200604010103.GB977471@lunn.ch>
References: <20200603215414.3606-1-rberg@berg-solutions.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200603215414.3606-1-rberg@berg-solutions.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 03, 2020 at 11:54:14PM +0200, Roelof Berg wrote:
> Corrected the MAC_CR configuration bits for 1 GBit operation. The data
> sheet allows MAC_CR(2:1) to be 10 and also 11 for 1 GBit/s speed, but
> only 10 works correctly.
> 
> Devices tested:
> Microchip Lan7431, fixed-phy mode
> Microchip Lan7430, normal phy mode
> 
> Signed-off-by: Roelof Berg <rberg@berg-solutions.de>

Fixes: 6f197fb63850 ("lan743x: Added fixed link and RGMII support")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

This was probably in the pull request for the merge window.

     Andrew