From: Pavel Machek <pavel@denx.de>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v18 4/4] leds: multicolor: Introduce a multicolor class definition
Date: Thu, 4 Jun 2020 15:21:02 +0200 [thread overview]
Message-ID: <20200604132102.GC7222@duo.ucw.cz> (raw)
In-Reply-To: <9a707fe6-31c6-da9e-9372-51ca21bf3c88@ti.com>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
Hi!
> > > +Description: read
> > > + Maximum intensity level for the LED color within the array.
> > > + The max intensities for each color must be entered based on the
> > > + color_index array.
> > I wonder if we should mention here that each LED within a cluster should
> > have the same maximum intensity for linear color lightness calculation
> > via brightness file.
>
> Does it really have to?
Yes it does. Anything else is unneccessarily complex.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2020-06-04 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 18:14 [PATCH v18 0/4] Multi Color LED Framework Patches Dan Murphy
2020-03-24 18:14 ` [PATCH v18 1/4] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-03-24 18:14 ` [PATCH v18 2/4] dt-bindings: leds: Add multicolor ID to the color ID list Dan Murphy
2020-03-24 18:14 ` [PATCH v18 3/4] " Dan Murphy
2020-03-24 18:14 ` [PATCH v18 4/4] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-03-24 18:41 ` Randy Dunlap
2020-03-24 18:52 ` Dan Murphy
2020-03-28 14:03 ` Jacek Anaszewski
2020-03-28 21:31 ` Dan Murphy
2020-03-29 12:47 ` Jacek Anaszewski
2020-03-29 15:14 ` Dan Murphy
2020-03-29 18:43 ` Jacek Anaszewski
2020-03-29 21:09 ` Dan Murphy
2020-06-04 13:21 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604132102.GC7222@duo.ucw.cz \
--to=pavel@denx.de \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).