* [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX
@ 2020-06-04 21:01 Max Filippov
2020-06-05 7:50 ` Miroslav Benes
0 siblings, 1 reply; 3+ messages in thread
From: Max Filippov @ 2020-06-04 21:01 UTC (permalink / raw)
To: linux-kernel; +Cc: Josh Poimboeuf, Linus Torvalds, Max Filippov
On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel
build fails with the following message:
kernel/module.c:3593:2: error: implicit declaration of function
‘module_enable_ro’;
Add empty module_enable_ro definition to fix the build.
Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
kernel/module.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/module.c b/kernel/module.c
index bca993c5f1bc..a74a29001814 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2038,6 +2038,7 @@ static void module_enable_x(const struct module *mod)
#else /* !CONFIG_ARCH_HAS_STRICT_MODULE_RWX */
static void module_enable_nx(const struct module *mod) { }
static void module_enable_x(const struct module *mod) { }
+static void module_enable_ro(const struct module *mod, bool after_init) {}
#endif /* CONFIG_ARCH_HAS_STRICT_MODULE_RWX */
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX
2020-06-04 21:01 [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX Max Filippov
@ 2020-06-05 7:50 ` Miroslav Benes
2020-06-05 9:57 ` Jessica Yu
0 siblings, 1 reply; 3+ messages in thread
From: Miroslav Benes @ 2020-06-05 7:50 UTC (permalink / raw)
To: Max Filippov; +Cc: linux-kernel, Josh Poimboeuf, Linus Torvalds, jeyu
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
Hi,
On Thu, 4 Jun 2020, Max Filippov wrote:
> On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel
> build fails with the following message:
>
> kernel/module.c:3593:2: error: implicit declaration of function
> ‘module_enable_ro’;
>
> Add empty module_enable_ro definition to fix the build.
>
> Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again")
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
I think the problem should disappear once Jessica sends her pull request
for modules tree.
Unfortunate though.
Miroslav
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX
2020-06-05 7:50 ` Miroslav Benes
@ 2020-06-05 9:57 ` Jessica Yu
0 siblings, 0 replies; 3+ messages in thread
From: Jessica Yu @ 2020-06-05 9:57 UTC (permalink / raw)
To: Miroslav Benes; +Cc: Max Filippov, linux-kernel, Josh Poimboeuf, Linus Torvalds
+++ Miroslav Benes [05/06/20 09:50 +0200]:
>Hi,
>
>On Thu, 4 Jun 2020, Max Filippov wrote:
>
>> On configurations with CONFIG_ARCH_HAS_STRICT_MODULE_RWX disabled kernel
>> build fails with the following message:
>>
>> kernel/module.c:3593:2: error: implicit declaration of function
>> ‘module_enable_ro’;
>>
>> Add empty module_enable_ro definition to fix the build.
>>
>> Fixes: e6eff4376e28 ("module: Make module_enable_ro() static again")
>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>
>I think the problem should disappear once Jessica sends her pull request
>for modules tree.
Yep, the pull request was sent today. So this should get resolved in
the next day or two.
Thanks,
Jessica
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-05 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 21:01 [PATCH] kernel/modules: fix build without ARCH_HAS_STRICT_MODULE_RWX Max Filippov
2020-06-05 7:50 ` Miroslav Benes
2020-06-05 9:57 ` Jessica Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).