From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <shuah@kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>
Subject: Re: [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support
Date: Fri, 5 Jun 2020 00:08:50 +0900 [thread overview]
Message-ID: <20200605000850.9dc797919133e3e245ceda99@kernel.org> (raw)
In-Reply-To: <20200603103343.2db5b5c6@gandalf.local.home>
Hi Steve,
On Wed, 3 Jun 2020 10:33:43 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 3 Jun 2020 08:51:13 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > On Tue, 2 Jun 2020 09:21:45 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > On Tue, 2 Jun 2020 18:08:31 +0900
> > > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > >
> > > > +++ b/tools/testing/selftests/ftrace/test.d/template
> > > > @@ -1,6 +1,7 @@
> > > > #!/bin/sh
> > > > # SPDX-License-Identifier: GPL-2.0
> > > > # description: %HERE DESCRIBE WHAT THIS DOES%
> > > > +# requires: %HERE LIST UP REQUIRED FILES%
> > >
> > > Not sure what you mean by "LIST UP". Perhaps you mean "LIST OF"?
> >
> > Ah, perhups we don't need UP. "list the required files" will be OK?
> >
> >
>
> Yes, that sounds much better.
>
> I tested out the patches with a few different configurations, and they all
> look good.
>
> Although I found that the irqsoff_tracer.tc (test for the preemptirqsoff
> tracer) changed from UNRESOLVED to UNSUPPORTED.
Yes, I think it should be unsupported if the kernel doesn't configure the
feature.
>
> I'll run a few more different configs and see what happens, but you can add:
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Thanks, and I've already sent v3.
https://lkml.kernel.org/r/159115200085.70027.6141550347953439240.stgit@devnote2
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-06-04 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 9:08 [PATCH v2 0/7] selftsts/ftrace: Add requires list for each test case Masami Hiramatsu
2020-06-02 9:08 ` [PATCH v2 1/7] selftests/ftrace: Allow ":" in description Masami Hiramatsu
2020-06-02 9:08 ` [PATCH v2 2/7] selftests/ftrace: Return unsupported for the unconfigured features Masami Hiramatsu
2020-06-02 9:08 ` [PATCH v2 3/7] selftests/ftrace: Add "requires:" list support Masami Hiramatsu
2020-06-02 13:21 ` Steven Rostedt
2020-06-02 23:51 ` Masami Hiramatsu
2020-06-03 14:33 ` Steven Rostedt
2020-06-04 15:08 ` Masami Hiramatsu [this message]
2020-06-04 15:16 ` Steven Rostedt
2020-06-02 9:08 ` [PATCH v2 4/7] selftests/ftrace: Convert required interface checks into requires list Masami Hiramatsu
2020-06-02 9:08 ` [PATCH v2 5/7] selftests/ftrace: Convert check_filter_file() with " Masami Hiramatsu
2020-06-02 9:09 ` [PATCH v2 6/7] selftests/ftrace: Support ":tracer" suffix for requires Masami Hiramatsu
2020-06-02 9:09 ` [PATCH v2 7/7] selftests/ftrace: Support ":README" " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605000850.9dc797919133e3e245ceda99@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).