From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0A34C433DF for ; Fri, 5 Jun 2020 16:27:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C7E62075B for ; Fri, 5 Jun 2020 16:27:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FvQ3gDTV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728483AbgFEQ13 (ORCPT ); Fri, 5 Jun 2020 12:27:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728452AbgFEQ1Y (ORCPT ); Fri, 5 Jun 2020 12:27:24 -0400 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 335ACC08C5C2; Fri, 5 Jun 2020 09:27:24 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id s21so8680671oic.9; Fri, 05 Jun 2020 09:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8ahUNwnpDeVrZ05fDXn6O0ce9OHzcqmipfeAiUk4NtQ=; b=FvQ3gDTVw28Qv+cd9RYJBHugxgyROQOBB9HT6IUhSlZoZWYMH+xNBAMMIRbMv/cnF4 BS4ndbRfZqbXCJN9iecIIRaVANGYTLZ6nExhI0ah3JhZpwJqRAxFL1Kwn5Xkg3CxvufI 0TdrkWSOtV2Md9V/IVhv90BjB7il6546MeZMpxFKoLs711eFmSwcSSilAnoJtWOrGMVz b87iblus/3Cx2TXA6cjJMpP9ZzsnO1AxXk79kvmeZl343troGPMI/9h7gU7qmu4V0XFQ mEBDTd9U0C+3A9gGC8mGa/bAoyiuQtkdPbyaQaDxtlh8s5YqyFGSH/6gNzIUIr2NqLaJ 0bAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8ahUNwnpDeVrZ05fDXn6O0ce9OHzcqmipfeAiUk4NtQ=; b=WJQyP7bfu5xqdvKjfljdZodZ5u6RHJNYuKrjCVV5w+bBinRQuVVg4p7VcT7uFd2GGG 7br/l2bsFHuJ+yF+LS3Mfiuy5REI46qNhFXI1lhwUP1lFFwA0lPG9Ldh6AFs9lWLjCXV P034WmzDuSKfFXkLwFR/ElueJ3mpO0WntQ7DQHmd+vK9EC2OVlIUsi8/ybD+MknF61oc AxpRzsT+0mk7bG36EBS+QtAqr7c0rfTX8UKlp2vBwvEUWi/EzWoejb/tcgt4BQLq7zv+ +0XDqTEC3KnrQD0iKqZ9LBeYDgiQt12sVufkVd79xsQ40/ec6Ip1UOzobNgCXvh1CeUR FTFw== X-Gm-Message-State: AOAM533zTCMQGxM0gPUYcRtmia/Sz0TrSeISC+D3ABgssJut2g15Tpfd hj9RE9t7zyUx8rjuLAQ00EA= X-Google-Smtp-Source: ABdhPJye/+D0bkUo+/ZfqemhiAPbod6iBp0Jn1ZIGvKrs9gn4Gru6uAEiOe/Mm3ytSEf+d6YWQwPPw== X-Received: by 2002:aca:f185:: with SMTP id p127mr2530729oih.120.1591374443539; Fri, 05 Jun 2020 09:27:23 -0700 (PDT) Received: from frodo.hsd1.co.comcast.net ([2601:284:8204:6ba0::aaac]) by smtp.googlemail.com with ESMTPSA id z13sm813894ooa.28.2020.06.05.09.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 09:27:22 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, linux-kernel@vger.kernel.org, akpm@linuxfoundation.org, gregkh@linuxfoundation.org Cc: linux@rasmusvillemoes.dk, Jim Cromie , Jonathan Corbet , Will Deacon , linux-doc@vger.kernel.org Subject: [PATCH 01/16] dyndbg-docs: eschew file /full/path query in docs Date: Fri, 5 Jun 2020 10:26:30 -0600 Message-Id: <20200605162645.289174-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200605162645.289174-1-jim.cromie@gmail.com> References: <20200605162645.289174-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Regarding: commit 2b6783191da7 ("dynamic_debug: add trim_prefix() to provide source-root relative paths") commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to make __FILE__ a relative path") 2nd commit broke dynamic-debug's "file $fullpath" query form, but nobody noticed because 1st commit had trimmed prefixes from control-file output, so the click-copy-pasting of fullpaths into new queries had ceased; that query form became unused. Removing the function is cleanest, but it could be useful in old-compiler corner cases, where __FILE__ still has /full/path, and it safely does nothing otherwize. So instead, quietly deprecate "file /full/path" query form, by removing all /full/paths examples in the docs. I skipped adding a back-compat note. Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 0dc2eb8e44e5..2854d418b31b 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -65,10 +65,10 @@ statements via:: nullarbor:~ # cat /dynamic_debug/control # filename:lineno [module]function flags format - /usr/src/packages/BUILD/sgi-enhancednfs-1.4/default/net/sunrpc/svc_rdma.c:323 [svcxprt_rdma]svc_rdma_cleanup =_ "SVCRDMA Module Removed, deregister RPC RDMA transport\012" - /usr/src/packages/BUILD/sgi-enhancednfs-1.4/default/net/sunrpc/svc_rdma.c:341 [svcxprt_rdma]svc_rdma_init =_ "\011max_inline : %d\012" - /usr/src/packages/BUILD/sgi-enhancednfs-1.4/default/net/sunrpc/svc_rdma.c:340 [svcxprt_rdma]svc_rdma_init =_ "\011sq_depth : %d\012" - /usr/src/packages/BUILD/sgi-enhancednfs-1.4/default/net/sunrpc/svc_rdma.c:338 [svcxprt_rdma]svc_rdma_init =_ "\011max_requests : %d\012" + net/sunrpc/svc_rdma.c:323 [svcxprt_rdma]svc_rdma_cleanup =_ "SVCRDMA Module Removed, deregister RPC RDMA transport\012" + net/sunrpc/svc_rdma.c:341 [svcxprt_rdma]svc_rdma_init =_ "\011max_inline : %d\012" + net/sunrpc/svc_rdma.c:340 [svcxprt_rdma]svc_rdma_init =_ "\011sq_depth : %d\012" + net/sunrpc/svc_rdma.c:338 [svcxprt_rdma]svc_rdma_init =_ "\011max_requests : %d\012" ... @@ -88,7 +88,7 @@ the debug statement callsites with any non-default flags:: nullarbor:~ # awk '$3 != "=_"' /dynamic_debug/control # filename:lineno [module]function flags format - /usr/src/packages/BUILD/sgi-enhancednfs-1.4/default/net/sunrpc/svcsock.c:1603 [sunrpc]svc_send p "svc_process: st_sendto returned %d\012" + net/sunrpc/svcsock.c:1603 [sunrpc]svc_send p "svc_process: st_sendto returned %d\012" Command Language Reference ========================== @@ -161,13 +161,12 @@ func func svc_tcp_accept file - The given string is compared against either the full pathname, the - src-root relative pathname, or the basename of the source file of - each callsite. Examples:: + The given string is compared against either the src-root relative + pathname, or the basename of the source file of each callsite. + Examples:: file svcsock.c - file kernel/freezer.c - file /usr/src/packages/BUILD/sgi-enhancednfs-1.4/default/net/sunrpc/svcsock.c + file kernel/freezer.c # ie column 1 of control file module The given string is compared against the module name -- 2.26.2