From: kernel test robot <lkp@intel.com>
To: Scott Branden <scott.branden@broadcom.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Brown <david.brown@linaro.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Shuah Khan <skhan@linuxfoundation.org>,
bjorn.andersson@linaro.org, Arnd Bergmann <arnd@arndb.de>
Cc: kbuild-all@lists.01.org, Mimi Zohar <zohar@linux.ibm.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] firmware: add offset to request_firmware_into_buf
Date: Sat, 6 Jun 2020 09:34:22 +0800 [thread overview]
Message-ID: <202006060948.CPS7CgtP%lkp@intel.com> (raw)
In-Reply-To: <20200605225959.12424-3-scott.branden@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 3691 bytes --]
Hi Scott,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200605]
[cannot apply to char-misc/char-misc-testing driver-core/driver-core-testing kselftest/next integrity/next-integrity linus/master v5.7 v5.7-rc7 v5.7-rc6 v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Scott-Branden/firmware-add-partial-read-support-in-request_firmware_into_buf/20200606-070430
base: af30725c132e2e5c5369b60369ff0771fde7d4ff
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/i2c/i2c-slave-eeprom.c: In function 'i2c_slave_init_eeprom_data':
>> drivers/i2c/i2c-slave-eeprom.c:131:9: error: too few arguments to function 'request_firmware_into_buf'
131 | ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/i2c/i2c-slave-eeprom.c:20:
include/linux/firmware.h:55:5: note: declared here
55 | int request_firmware_into_buf(const struct firmware **firmware_p,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/request_firmware_into_buf +131 drivers/i2c/i2c-slave-eeprom.c
389be323cfac38 Wolfram Sang 2014-11-18 122
e804f0a78e9e43 Björn Ardö 2020-04-24 123 static int i2c_slave_init_eeprom_data(struct eeprom_data *eeprom, struct i2c_client *client,
e804f0a78e9e43 Björn Ardö 2020-04-24 124 unsigned int size)
e804f0a78e9e43 Björn Ardö 2020-04-24 125 {
e804f0a78e9e43 Björn Ardö 2020-04-24 126 const struct firmware *fw;
e804f0a78e9e43 Björn Ardö 2020-04-24 127 const char *eeprom_data;
e804f0a78e9e43 Björn Ardö 2020-04-24 128 int ret = device_property_read_string(&client->dev, "firmware-name", &eeprom_data);
e804f0a78e9e43 Björn Ardö 2020-04-24 129
e804f0a78e9e43 Björn Ardö 2020-04-24 130 if (!ret) {
e804f0a78e9e43 Björn Ardö 2020-04-24 @131 ret = request_firmware_into_buf(&fw, eeprom_data, &client->dev,
e804f0a78e9e43 Björn Ardö 2020-04-24 132 eeprom->buffer, size);
e804f0a78e9e43 Björn Ardö 2020-04-24 133 if (ret)
e804f0a78e9e43 Björn Ardö 2020-04-24 134 return ret;
e804f0a78e9e43 Björn Ardö 2020-04-24 135 release_firmware(fw);
e804f0a78e9e43 Björn Ardö 2020-04-24 136 } else {
e804f0a78e9e43 Björn Ardö 2020-04-24 137 /* An empty eeprom typically has all bits set to 1 */
e804f0a78e9e43 Björn Ardö 2020-04-24 138 memset(eeprom->buffer, 0xff, size);
e804f0a78e9e43 Björn Ardö 2020-04-24 139 }
e804f0a78e9e43 Björn Ardö 2020-04-24 140 return 0;
e804f0a78e9e43 Björn Ardö 2020-04-24 141 }
e804f0a78e9e43 Björn Ardö 2020-04-24 142
:::::: The code at line 131 was first introduced by commit
:::::: e804f0a78e9e43f0105e1bc3e264894b3898e970 i2c: slave-eeprom: Make it possible to pre-load eeprom data
:::::: TO: Björn Ardö <bjorn.ardo@axis.com>
:::::: CC: Wolfram Sang <wsa@the-dreams.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56373 bytes --]
next prev parent reply other threads:[~2020-06-06 2:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 22:59 [PATCH v6 0/8] firmware: add partial read support in request_firmware_into_buf Scott Branden
2020-06-05 22:59 ` [PATCH v6 1/8] fs: introduce kernel_pread_file* support Scott Branden
2020-06-06 3:20 ` Matthew Wilcox
2020-06-06 4:56 ` Scott Branden
2020-06-05 22:59 ` [PATCH v6 2/8] firmware: add offset to request_firmware_into_buf Scott Branden
2020-06-06 1:34 ` kernel test robot [this message]
2020-06-05 22:59 ` [PATCH v6 3/8] test_firmware: add partial read support for request_firmware_into_buf Scott Branden
2020-06-05 22:59 ` [PATCH v6 4/8] firmware: test partial file reads of request_firmware_into_buf Scott Branden
2020-06-05 22:59 ` [PATCH v6 5/8] bcm-vk: add bcm_vk UAPI Scott Branden
2020-06-05 22:59 ` [PATCH v6 6/8] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-06-05 22:59 ` [PATCH v6 7/8] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
2020-06-05 22:59 ` [PATCH v6 8/8] ima: add FIRMWARE_PARTIAL_READ support Scott Branden
2020-06-05 23:19 ` Mimi Zohar
2020-06-05 23:31 ` Scott Branden
2020-06-05 23:48 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006060948.CPS7CgtP%lkp@intel.com \
--to=lkp@intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=scott.branden@broadcom.com \
--cc=skhan@linuxfoundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).