From: Manivannan Sadhasivam <mani@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
patong.mxl@gmail.com
Subject: Re: [PATCH v3 0/2] Add support for MaxLinear/Exar USB to serial converters
Date: Sat, 6 Jun 2020 17:57:35 +0530 [thread overview]
Message-ID: <20200606122735.GB31973@Mani-XPS-13-9360> (raw)
In-Reply-To: <20200605131355.18107dbb@coco.lan>
Hi Mauro,
On Fri, Jun 05, 2020 at 01:13:55PM +0200, Mauro Carvalho Chehab wrote:
> Em Fri, 1 May 2020 00:19:22 +0530
> mani@kernel.org escreveu:
>
> > From: Manivannan Sadhasivam <mani@kernel.org>
> >
> > Hello,
> >
> > This series adds support for MaxLinear/Exar USB to serial converters.
> > This driver only supports XR21V141X series but it can easily be extended
> > to other series in future.
> >
> > This driver is inspired from the initial one submitted by Patong Yang:
> >
> > https://patchwork.kernel.org/patch/10543261/
> >
> > While the initial driver was a custom tty USB driver exposing whole
> > new serial interface ttyXRUSBn, this version is completely based on USB
> > serial core thus exposing the interfaces as ttyUSBn. This will avoid
> > the overhead of exposing a new USB serial interface which the userspace
> > tools are unaware of.
>
> Hmm... I guess you also need the enclosed patch, to ensure that cdc_acm
> won't try to hijack it, when the Kernel is built with both drivers.
>
Ah right. I will include this patch in next iteration. Many thanks!
Regards,
Mani
> Thanks,
> Mauro
>
> [PATCH] usb: cdc-acm: ignore Exar XR21V141X when serial driver is
> built
>
> The RTS/CTS line discipline for this device doesn't follow
> the standard. So, in order to properly support TX, a separate
> driver is needed.
>
> Ensure that cdc_acm will ignore it during probe time, if the
> Kernel is built with support for it.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index ded8d93834ca..f87288834ded 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1889,7 +1889,11 @@ static const struct usb_device_id acm_ids[] = {
> .driver_info = IGNORE_DEVICE,
> },
> #endif
> -
> +#if IS_ENABLED(CONFIG_USB_SERIAL_XR)
> + { USB_DEVICE(0x04e2, 0x1410), /* XR21V141X uses a different rts/cts discipline */
> + .driver_info = IGNORE_DEVICE,
> + },
> +#endif
> /*Samsung phone in firmware update mode */
> { USB_DEVICE(0x04e8, 0x685d),
> .driver_info = IGNORE_DEVICE,
>
next prev parent reply other threads:[~2020-06-06 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 18:49 [PATCH v3 0/2] Add support for MaxLinear/Exar USB to serial converters mani
2020-04-30 18:49 ` [PATCH v3 1/2] usb: serial: Add MaxLinear/Exar USB to Serial driver mani
2020-05-18 6:07 ` Greg KH
2020-05-19 12:33 ` Johan Hovold
2020-06-06 18:45 ` Manivannan Sadhasivam
2020-04-30 18:49 ` [PATCH v3 2/2] usb: serial: xr_serial: Add gpiochip support mani
2020-05-19 13:07 ` Johan Hovold
2020-05-27 3:09 ` Manivannan Sadhasivam
2020-05-29 9:00 ` Johan Hovold
2020-05-16 7:06 ` [PATCH v3 0/2] Add support for MaxLinear/Exar USB to serial converters Manivannan Sadhasivam
2020-06-05 11:13 ` Mauro Carvalho Chehab
2020-06-06 12:27 ` Manivannan Sadhasivam [this message]
2020-06-05 12:40 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200606122735.GB31973@Mani-XPS-13-9360 \
--to=mani@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=patong.mxl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).