From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4630C433E0 for ; Sat, 6 Jun 2020 15:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8547C2073E for ; Sat, 6 Jun 2020 15:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591456137; bh=Den8Wsncp0pVwO031pIyBfHrfFxB7H6+G53zJ8VfhoA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=vFrMVsEeIlPXPluPNRcdmC6RmFluXys6vkCSmQjwD84Gm1uko/fm1IoSDszVob1aP DxFpffnR1Vzhkl5mw7Xayd9d/ie/XXDA+5kuw+hQGEJAcxoqg3VTWaOocc1VgLdCPX OgAGB3tf9bLqG5L3mYg5V/LeDHVoGaM1sHejhI/E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728794AbgFFPI5 (ORCPT ); Sat, 6 Jun 2020 11:08:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:37368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbgFFPI4 (ORCPT ); Sat, 6 Jun 2020 11:08:56 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 867482067B; Sat, 6 Jun 2020 15:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591456135; bh=Den8Wsncp0pVwO031pIyBfHrfFxB7H6+G53zJ8VfhoA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PlUACo8AoILX9GGQOL8MYcHk8OAP77lR/pDv0d0YjogMbGUT9PsTnVH9jkLP3O1xj ttldBkZzuvcQYoHCIhtO5IY6kcZE7PpHTN2D3j1XGmBmUauw8/crs4T4WYMTNldtfE anSW6trgup0VmAxpjURHnpy44DzvkV0QTVYmo1Oc= Date: Sat, 6 Jun 2020 16:08:51 +0100 From: Jonathan Cameron To: Tomasz Duszynski Cc: , , , , , Subject: Re: [PATCH v4 4/4] dt-bindings: iio: scd30: add device binding file Message-ID: <20200606160851.6433843e@archlinux> In-Reply-To: <20200603084441.33952-5-tomasz.duszynski@octakon.com> References: <20200603084441.33952-1-tomasz.duszynski@octakon.com> <20200603084441.33952-5-tomasz.duszynski@octakon.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Jun 2020 10:44:41 +0200 Tomasz Duszynski wrote: > Add SCD30 sensor binding file. > > Signed-off-by: Tomasz Duszynski Looks fine to me (as do the previous 2 patches), however I'd ideally like to leave time for a DT review from Rob. Thanks, Jonathan > --- > .../iio/chemical/sensirion,scd30.yaml | 68 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > > diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > new file mode 100644 > index 000000000000..40d87346ff4c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/chemical/sensirion,scd30.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sensirion SCD30 carbon dioxide sensor > + > +maintainers: > + - Tomasz Duszynski > + > +description: | > + Air quality sensor capable of measuring co2 concentration, temperature > + and relative humidity. > + > +properties: > + compatible: > + enum: > + - sensirion,scd30 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: true > + > + sensirion,sel-gpios: > + description: GPIO connected to the SEL line > + maxItems: 1 > + > + sensirion,pwm-gpios: > + description: GPIO connected to the PWM line > + maxItems: 1 > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + # include > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + co2-sensor@61 { > + compatible = "sensirion,scd30"; > + reg = <0x61>; > + vdd-supply = <&vdd>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + - | > + # include > + serial { > + co2-sensor { > + compatible = "sensirion,scd30"; > + vdd-supply = <&vdd>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5db4b446c8ba..0ab9cf39e051 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15140,6 +15140,7 @@ F: include/uapi/linux/phantom.h > SENSIRION SCD30 CARBON DIOXIDE SENSOR DRIVER > M: Tomasz Duszynski > S: Maintained > +F: Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > F: drivers/iio/chemical/scd30.h > F: drivers/iio/chemical/scd30_core.c > F: drivers/iio/chemical/scd30_i2c.c