linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: xypron.glpk@gmx.de
Cc: vishal@chelsio.com, kuba@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] cxgb4: fix cxgb4_uld_in_use() not used error
Date: Mon, 08 Jun 2020 19:07:37 -0700 (PDT)	[thread overview]
Message-ID: <20200608.190737.2279619081686680210.davem@davemloft.net> (raw)
In-Reply-To: <20200608005823.911290-1-xypron.glpk@gmx.de>

From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Mon,  8 Jun 2020 02:58:23 +0200

> When building without CONFIG_CHELSIO_TLS_DEVICE a build error occurs:
> 
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:666:13: error:
> ‘cxgb4_uld_in_use’ defined but not used [-Werror=unused-function]
>   666 | static bool cxgb4_uld_in_use(struct adapter *adap)
>       |             ^~~~~~~~~~~~~~~~
> 
> Guard cxgb4_uld_in_use() with #ifdef CONFIG_CHELSIO_TLS_DEVICE.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>


Please see commit ef1c75593e770aff8749e902aa0deb6855a3f485, which already
does this.

Thank you.

      reply	other threads:[~2020-06-09  2:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08  0:58 [PATCH 1/1] cxgb4: fix cxgb4_uld_in_use() not used error Heinrich Schuchardt
2020-06-09  2:07 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200608.190737.2279619081686680210.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vishal@chelsio.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).