From: David Miller <davem@davemloft.net>
To: geliangtang@gmail.com
Cc: mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net,
kuba@kernel.org, pabeni@redhat.com,
peter.krystad@linux.intel.com, netdev@vger.kernel.org,
mptcp@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] mptcp: bugfix for RM_ADDR option parsing
Date: Mon, 08 Jun 2020 19:11:08 -0700 (PDT) [thread overview]
Message-ID: <20200608.191108.1901661787245617914.davem@davemloft.net> (raw)
In-Reply-To: <5ec9759a19d4eba5f7f9006354da2cfeb39fa839.1591612830.git.geliangtang@gmail.com>
From: Geliang Tang <geliangtang@gmail.com>
Date: Mon, 8 Jun 2020 18:47:54 +0800
> In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the
> "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet:
>
> +-------+-------+---------------+
> |Subtype|(resvd)| Address ID |
> +-------+-------+---------------+
> | |
> ptr ptr+1
>
> We should set mp_opt->rm_id to the value of "ptr+1", not "ptr". This patch
> will fix this bug.
>
> Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling")
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> Changes in v2:
> - Add "-net" subject and "Fixes" tag as Matt suggested.
Applied and queued up for v5.7 -stable, thanks!
prev parent reply other threads:[~2020-06-09 2:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 10:47 [PATCH net v2] mptcp: bugfix for RM_ADDR option parsing Geliang Tang
2020-06-08 11:19 ` Matthieu Baerts
2020-06-09 2:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608.191108.1901661787245617914.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geliangtang@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.01.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.krystad@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).