From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"J . P . Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH] Revert "sh: add missing EXPORT_SYMBOL() for __delay"
Date: Mon, 8 Jun 2020 10:06:36 +0200 [thread overview]
Message-ID: <20200608080636.27862-1-geert+renesas@glider.be> (raw)
This reverts commit d1f56f318d234fc5db230af2f3e0088f689ab3c0.
__delay() is an internal implementation detail on several architectures.
Drivers should not call __delay() directly, as it has non-standardized
semantics, or may not even exist.
Hence there is no need to export __delay() to modules.
See also include/asm-generic/delay.h:
/* Undefined functions to get compile-time errors */
...
extern void __delay(unsigned long loops);
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Sorry for missing this when Adrian posted his list of mising patches.
References:
[1] "Re: Build regressions/improvements in v5.4-rc2"
https://lore.kernel.org/r/CAMuHMdUERaoHLNKi03zCuYi7NevgBFjXrV=pt0Yy=HOeRiL25Q@mail.gmail.com/
[2] "Re: [PATCH] sh: add missing EXPORT_SYMBOL() for __delay"
http://lore.kernel.org/r/CAMuHMdWb_ipn7FVHbz8=PTdGod=MW+2xHY7yuq3yJcWwNnDvcg@mail.gmail.com
---
arch/sh/lib/delay.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sh/lib/delay.c b/arch/sh/lib/delay.c
index 540e670dbafcd826..dad8e6a54906bece 100644
--- a/arch/sh/lib/delay.c
+++ b/arch/sh/lib/delay.c
@@ -29,7 +29,6 @@ void __delay(unsigned long loops)
: "0" (loops)
: "t");
}
-EXPORT_SYMBOL(__delay);
inline void __const_udelay(unsigned long xloops)
{
--
2.17.1
reply other threads:[~2020-06-08 8:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608080636.27862-1-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).