From: Peter Zijlstra <peterz@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
frederic@kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: blk-softirq vs smp_call_function_single_async()
Date: Mon, 8 Jun 2020 17:58:33 +0200 [thread overview]
Message-ID: <20200608155833.GC2531@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200608154557.GA26611@infradead.org>
On Mon, Jun 08, 2020 at 08:45:57AM -0700, Christoph Hellwig wrote:
> On Mon, Jun 08, 2020 at 01:58:00PM +0200, Peter Zijlstra wrote:
> > Hi Jens,
> >
> > I've been going through smp_call_function_single_async() users and
> > stumbled upon blk-softirq.c, which has:
> >
> > static int raise_blk_irq(int cpu, struct request *rq)
> > {
> > if (cpu_online(cpu)) {
> > call_single_data_t *data = &rq->csd;
> >
> > data->func = trigger_softirq;
> > data->info = rq;
> > data->flags = 0;
> >
> > smp_call_function_single_async(cpu, data);
> > return 0;
> > }
> >
> > return 1;
> > }
> >
> > What, if anything, guarantees rq->csd is not already in use at that
> > time?
>
> A request can only be completed once.
Sure, but that doesn't help.
CPU0 CPU1
raise_blk_irq() BLOCK_SOFTIRQ
IPI -> CPU1
// picks up thing from CPU0
req->complete(req);
<big hole where CSD is active and request completed>
<IPI>
trigger_softirq()
What happens to a struct request after completion, is it free()d
or reused? If reused, how do we guarantee CSD completion before
free()ing?
next prev parent reply other threads:[~2020-06-08 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 11:58 blk-softirq vs smp_call_function_single_async() Peter Zijlstra
2020-06-08 15:45 ` Christoph Hellwig
2020-06-08 15:58 ` Peter Zijlstra [this message]
2020-06-08 16:33 ` Christoph Hellwig
2020-06-08 16:40 ` Peter Zijlstra
2020-06-08 16:42 ` Christoph Hellwig
2020-06-09 13:38 ` Peter Zijlstra
2020-06-08 21:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608155833.GC2531@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=axboe@kernel.dk \
--cc=frederic@kernel.org \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).