From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lukasz.luba@arm.com,
james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com,
dave.martin@arm.com, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v8 0/9] SCMI Notifications Core Support
Date: Mon, 8 Jun 2020 18:05:50 +0100 [thread overview]
Message-ID: <20200608170550.GE13622@bogus> (raw)
In-Reply-To: <20200520081118.54897-1-cristian.marussi@arm.com>
Hi Cristian,
On Wed, May 20, 2020 at 09:11:09AM +0100, Cristian Marussi wrote:
> Hi all,
>
> this series wants to introduce SCMI Notification Support, built on top of
> the standard Kernel notification chain subsystem.
>
> At initialization time each SCMI Protocol takes care to register with the
> new SCMI notification core the set of its own events which it intends to
> support.
>
> Using the API exposed via scmi_handle.notify_ops a Kernel user can register
> its own notifier_t callback (via a notifier_block as usual) against any
> registered event as identified by the tuple:
>
> (proto_id, event_id, src_id)
>
> where src_id represents a generic source identifier which is protocol
> dependent like domain_id, performance_id, sensor_id and so forth.
> (users can anyway do NOT provide any src_id, and subscribe instead to ALL
> the existing (if any) src_id sources for that proto_id/evt_id combination)
>
> Each of the above tuple-specified eventis will be served on its own
> dedicated blocking notification chain, dynamically allocated on-demand when
> at least one user has shown interest on that event.
>
> Upon a notification delivery all the users' registered notifier_t callbacks
> will be in turn invoked and fed with the event_id as @action param and a
> generated custom per-event struct _report as @data param.
> (as in include/linux/scmi_protocol.h)
>
> The final step of notification delivery via users' callback invocation is
> instead delegated to a pool of deferred workers (Kernel cmwq): each
> SCMI protocol has its own dedicated worker and dedicated queue to push
> events from the rx ISR to the worker.
>
> Based on scmi-next/for-next/scmi 5.7 [1], on top of:
>
> commit f7199cf48902 ("firmware: arm_scmi: Fix return error code in
> smc_send_message")
>
> This series has been tested on JUNO with an experimental firmware only
> supporting Perf Notifications.
>
Thanks for working on this. Looks mostly OK. I have few minor comments
or queries.
--
Regards,
Sudeep
prev parent reply other threads:[~2020-06-08 17:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:11 [PATCH v8 0/9] SCMI Notifications Core Support Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 1/9] firmware: arm_scmi: Add notification protocol-registration Cristian Marussi
2020-06-08 17:02 ` Sudeep Holla
2020-06-16 19:58 ` Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 2/9] firmware: arm_scmi: Add notification callbacks-registration Cristian Marussi
2020-06-08 17:03 ` Sudeep Holla
2020-06-17 23:20 ` Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 3/9] firmware: arm_scmi: Add notification dispatch and delivery Cristian Marussi
2020-06-08 17:03 ` Sudeep Holla
2020-06-17 23:31 ` Cristian Marussi
2020-06-18 8:37 ` Lukasz Luba
2020-05-20 8:11 ` [PATCH v8 4/9] firmware: arm_scmi: Enable notification core Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 5/9] firmware: arm_scmi: Add Power notifications support Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 6/9] firmware: arm_scmi: Add Perf " Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 7/9] firmware: arm_scmi: Add Sensor " Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 8/9] firmware: arm_scmi: Add Reset " Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 9/9] firmware: arm_scmi: Add Base " Cristian Marussi
2020-06-08 17:02 ` Sudeep Holla
2020-06-18 17:24 ` Cristian Marussi
2020-06-08 17:05 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608170550.GE13622@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=cristian.marussi@arm.com \
--cc=dave.martin@arm.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).