From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD91C433DF for ; Mon, 8 Jun 2020 18:44:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 275B420775 for ; Mon, 8 Jun 2020 18:44:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mL+GNA2F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725978AbgFHSod (ORCPT ); Mon, 8 Jun 2020 14:44:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgFHSoc (ORCPT ); Mon, 8 Jun 2020 14:44:32 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1500AC08C5C2; Mon, 8 Jun 2020 11:44:32 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id x27so10856668lfg.9; Mon, 08 Jun 2020 11:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pyL9AG+EFCBzwXFwLDd8EbAbgZhHaqJwjdz7TgHOiYw=; b=mL+GNA2FG4HsXvVnkoxTb434Y31Detzb31ZKCm4kR2pgFjmdv+nPZF0Gn1cITJs8OZ n3a9HF4U80TzRPfJ24C/HyWubtl5UxuJ7xWijJMABqaf09jQNu392TXmiYaWIb1AZCDT dban/QRWM4802ANFK4wPRycuZ3ga7WPUTsEdX+tIZXAB9pFefmspQ4xuMCoD7uudQu7E bJ+0VtwTxmWVvJK/KMhhw4w7Qk8D7ZUwGd71EyhG/9o4A5CFlH5zruanv1xgjmWqK5GQ btON9cG8TyuB5pUpeMvBgW7IWZlrsN6LWRytgy8j7+f2vU1Myi54ytGnb40KKBA4YqhY rMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pyL9AG+EFCBzwXFwLDd8EbAbgZhHaqJwjdz7TgHOiYw=; b=KyXdjUwXvHCZHMn+ksI3KVAyOieYe07yGLiBSsxzmhPn9noSY3qMa5DqKMPg8Va6wM iYIU+2ge1puNqlDpEQxlhzPI4DsKRvN3FZGzRWBW5qyrmjmrZZ1s2rdpVdObk1H+PKg+ o4/fDWIWV9ZIHu2Rq59tflOBhnuRnQa7NcWqZBnF2zlaVJSRH2IyV3c48eyu7nC4xfKF Xy2DedMLdyIrD+fqk2kwMg673du8ZH4LEULJ4rkSsn38nB75/Wa7jGACru/uQlmLuvAI seoTlUYJtSB5p5HLLrRI2TXPEZ+cVfseH6QRSY09eRCPCKoa5JSnvQzkZ/py3sIbTAAa 0uNQ== X-Gm-Message-State: AOAM533Xho8XV/kM8PIMJdVRGYG5J33evUzpLctv3OaTqReuZY/+PkXK A12MUZbFDsum7fKP9P88MzrnJqZ7C2Y= X-Google-Smtp-Source: ABdhPJxPZTBUgw8IjTEOAqpsENgOgvgi5A4vpLqMkcNAoipP9+5qKn2/LrcZDOZ3LFXtxbdR1Eoc1A== X-Received: by 2002:a19:48c9:: with SMTP id v192mr13474983lfa.20.1591641870507; Mon, 08 Jun 2020 11:44:30 -0700 (PDT) Received: from rikard (h-82-196-111-136.NA.cust.bahnhof.se. [82.196.111.136]) by smtp.gmail.com with ESMTPSA id o4sm4532793lfb.75.2020.06.08.11.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 11:44:29 -0700 (PDT) From: Rikard Falkeborn X-Google-Original-From: Rikard Falkeborn Date: Mon, 8 Jun 2020 20:44:26 +0200 To: Andy Shevchenko Cc: Rikard Falkeborn , Andrew Morton , Arnd Bergmann , Emil Velikov , Kees Cook , Linus Walleij , Linux-Arch , Linux Kernel Mailing List , kbuild test robot , Syed Nayyar Waris , William Breathitt Gray , Masahiro Yamada Subject: Re: [PATCH v2 2/2] bits: Add tests of GENMASK Message-ID: <20200608184426.GB899@rikard> References: <20200604233003.GA102768@rikard> <20200607203411.70913-1-rikard.falkeborn@gmail.com> <20200607203411.70913-2-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 11:08:04AM +0300, Andy Shevchenko wrote: > On Sun, Jun 7, 2020 at 11:34 PM Rikard Falkeborn > wrote: > > > > Add tests of GENMASK and GENMASK_ULL. > > > > A few test cases that should fail compilation are provided under ifdef. > > > > Thank you very much! > > > * New patch. First time I wrote a KUnittest so may be room for > > improvements... > > Have you considered to unify them with existing test_bitops.h? test_bitops.c seems to be tests for macros/functions in bitops.h, so I figured it would make more sense to add tests of bits.h in test_bits.c. But I don't have a strong opinion about it. If you prefer, I'll move them to test_bitops.c. Rikard > > -- > With Best Regards, > Andy Shevchenko