From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF770C433DF for ; Mon, 8 Jun 2020 23:20:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84B902074B for ; Mon, 8 Jun 2020 23:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591658449; bh=cpNcsyP96V0xPvcpUSTt8b+S6Y2aJ4SjDn/xXmL06hI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fHquo6amKv3wb4Hv+hwB49PS2s94MpBiZWzOAMsf4pwlm4H4vZaUZCKGJvJUjD2a/ FV6oDNGPNbRwq5rVznyjtiPPqAaJUCoUN2GBixoCpP2/IjVKi/Y5UBnLGIvg6QFTn0 SE9jaIXCKSvgg/PWp+7jWNBWq06WCohzSzSbnDM4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731025AbgFHXUo (ORCPT ); Mon, 8 Jun 2020 19:20:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:38084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727887AbgFHXQk (ORCPT ); Mon, 8 Jun 2020 19:16:40 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABCE420842; Mon, 8 Jun 2020 23:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591658200; bh=cpNcsyP96V0xPvcpUSTt8b+S6Y2aJ4SjDn/xXmL06hI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SEdkfIoywhUtSCHGrsSkzonhdqhbw6AK3i1tfPGAyzPPSGH0DzT3kT+giH5espemC xpyAp+fFP9DmB3TapTkLrTGLbGzOn/jKj5MOY6RMJzw/qeeDJ0ulAAg6SGHh34frCb Rvsk10x6hew5ksblmdzErIWjn6zGFDY4c95YktOw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Manivannan Sadhasivam , kbuild test robot , Julia Lawall , Bjorn Andersson , "David S . Miller" , Greg Kroah-Hartman , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.6 220/606] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue() Date: Mon, 8 Jun 2020 19:05:45 -0400 Message-Id: <20200608231211.3363633-220-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200608231211.3363633-1-sashal@kernel.org> References: <20200608231211.3363633-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manivannan Sadhasivam [ Upstream commit d28ea1fbbf437054ef339afec241019f2c4e2bb6 ] Once the traversal of the list is completed with list_for_each_entry(), the iterator (node) will point to an invalid object. So passing this to qrtr_local_enqueue() which is outside of the iterator block is erroneous eventhough the object is not used. So fix this by passing NULL to qrtr_local_enqueue(). Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") Reported-by: kbuild test robot Reported-by: Julia Lawall Signed-off-by: Manivannan Sadhasivam Reviewed-by: Bjorn Andersson Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index b7b854621c26..9d38c14d251a 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -855,7 +855,7 @@ static int qrtr_bcast_enqueue(struct qrtr_node *node, struct sk_buff *skb, } mutex_unlock(&qrtr_node_lock); - qrtr_local_enqueue(node, skb, type, from, to); + qrtr_local_enqueue(NULL, skb, type, from, to); return 0; } -- 2.25.1