From: Mark Brown <broonie@kernel.org>
To: Pi-Hsun Shih <pihsun@chromium.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK"
<linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator
Date: Tue, 9 Jun 2020 12:21:57 +0100 [thread overview]
Message-ID: <20200609112157.GC4583@sirena.org.uk> (raw)
In-Reply-To: <20200609080001.121499-2-pihsun@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
On Tue, Jun 09, 2020 at 03:59:54PM +0800, Pi-Hsun Shih wrote:
> + google,remote-regulator:
> + description: Identifier for the voltage regulator to ChromeOS EC.
> + $ref: "/schemas/types.yaml#/definitions/uint32"
As I said in reviewing the patch this is a bit weird - it feels like it
should be a reg property on a bus rather than a property like this. How
exactly to these devices get created - can the core device for the EC
enumerate the regulators that are present?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-09 11:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 7:59 [PATCH 0/2] Add support for voltage regulator on ChromeOS EC Pi-Hsun Shih
2020-06-09 7:59 ` [PATCH 1/2] dt-bindings: regulator: Add DT binding for cros-ec-regulator Pi-Hsun Shih
2020-06-09 11:21 ` Mark Brown [this message]
2020-06-09 7:59 ` [PATCH 2/2] regulator: Add driver " Pi-Hsun Shih
2020-06-09 11:19 ` Mark Brown
2020-06-10 4:31 ` Pi-Hsun Shih
2020-06-10 10:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609112157.GC4583@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pihsun@chromium.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).